Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callback Support (alternative implementation) #908

Open
wants to merge 68 commits into
base: gh-pages
Choose a base branch
from
Open

Callback Support (alternative implementation) #908

wants to merge 68 commits into from

Commits on Apr 12, 2018

  1. Added tests.

    Rebecca Stevens committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    1da64f8 View commit details
    Browse the repository at this point in the history

  2. Added callback parameter to minify.

    Rebecca Stevens committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    736a572 View commit details
    Browse the repository at this point in the history

  3. Added callback parameter to minifyCSS and minifyJS.

    Rebecca Stevens committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    b773ab4 View commit details
    Browse the repository at this point in the history

  4. Create a placeholder class for async text.

    Rebecca Stevens committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    fdf4ca3 View commit details
    Browse the repository at this point in the history

  5. When processing entries in the buffer, make sure they are a string. 

    This allows instances of AsyncTextPlaceholder to be put into the buffer.
    Rebecca Stevens committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    b71cc2f View commit details
    Browse the repository at this point in the history

  6. The result is only finalize and returned if there are no async tasks … 

    …running.
    Rebecca Stevens committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    d9104ac View commit details
    Browse the repository at this point in the history

  7. Set up minifyJS and minifyCSS to be able to complete asynchronously.

    Rebecca Stevens committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    79e5f8d View commit details
    Browse the repository at this point in the history

  8. Added error handling.

    Rebecca Stevens committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    7b2864f View commit details
    Browse the repository at this point in the history

  9. Removed extra empty lines.

    Rebecca Stevens committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    99b55ed View commit details
    Browse the repository at this point in the history

  10. "along side" --> "alongside"

    Rebecca Stevens committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    a7c0584 View commit details
    Browse the repository at this point in the history

  11. Added extra check to 'minify error with callback' test.

    Rebecca Stevens committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    ee14967 View commit details
    Browse the repository at this point in the history

  12. Added a test to ensure the minifyCSS and miniftJS callbacks can only … 

    …be called once.
    Rebecca Stevens committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    3a6846d View commit details
    Browse the repository at this point in the history

  13. Fixed bug with AsyncTextPlaceholder not being able to have the emptyS… 

    …tring as its value.
    Rebecca Stevens committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    390eacb View commit details
    Browse the repository at this point in the history

  14. Fixed bug with error not being given to callback after all async task… 

    …s have completed.
    Rebecca Stevens committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    e74fcf1 View commit details
    Browse the repository at this point in the history

  15. Added callback information to the readme.

    Rebecca Stevens committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    d77176a View commit details
    Browse the repository at this point in the history

  16. Refactored.

    @RebeccaStevens
    RebeccaStevens committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    cdc653b View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2018

  1. Refactored - Async tasks now do not start until after all sync code h… 

    …as finished.
    Rebecca Stevens committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    28c1ac3 View commit details
    Browse the repository at this point in the history

  2. Added inline callback tests.

    Rebecca Stevens committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    80f5ad9 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2018

  1. All test now test both synchronously and asynchronously.

    Rebecca Stevens committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    c64327a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'gh-pages' into callback-support-alt

    Rebecca Stevens committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    9247ece View commit details
    Browse the repository at this point in the history

  3. Fix potential issue with placeholder not being at the same index it w… 

    …as put at when it comes to replacing it with content.
    Rebecca Stevens committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    ee3054f View commit details
    Browse the repository at this point in the history

  4. Refactored.

    Rebecca Stevens committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    aa56a66 View commit details
    Browse the repository at this point in the history

  5. Asynchronously tests now give more helpful feedback when an error occ… 

    …urs.
    Rebecca Stevens committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    f82ca4a View commit details
    Browse the repository at this point in the history

  6. Created a test_minify_error function to test for expected errors.

    Rebecca Stevens committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    314c4b8 View commit details
    Browse the repository at this point in the history

  7. Fixed issue with code still executing after callback.

    Rebecca Stevens committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    5bcb767 View commit details
    Browse the repository at this point in the history

  8. Initial step to get normalizeAttr working with a callback.

    Rebecca Stevens committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    3f2bc24 View commit details
    Browse the repository at this point in the history

  9. Fixed conversion from sync to async minifyJS and minifyCSS.

    Rebecca Stevens committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    0a5e9b8 View commit details
    Browse the repository at this point in the history

  10. Refactored.

    Rebecca Stevens committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    fe5da2d View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2018

  1. Merge branch 'gh-pages' into callback-support-alt

    Rebecca Stevens committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    377e049 View commit details
    Browse the repository at this point in the history

  2. Async start tasks now modifies the buffer inplace.

    Rebecca Stevens committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    f23648e View commit details
    Browse the repository at this point in the history

  3. removeStartTag and removeEndTag now take an indexBound which prevents… 

    … modification to the buffer at or past its value.
    Rebecca Stevens committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    37b4ea7 View commit details
    Browse the repository at this point in the history

  4. Added callbacks to more functions and wrapped them in AsyncTasks.

    Rebecca Stevens committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    cebb717 View commit details
    Browse the repository at this point in the history

  5. squashTrailingWhitespace now uses indexBound.

    Rebecca Stevens committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    7067027 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2018

  1. Fixed issue with bad error reporting when the minify function never c… 

    …alls it's callback.
    Rebecca Stevens committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    690f85e View commit details
    Browse the repository at this point in the history

  2. Removed placeholders as they are not necessary when everything will b… 

    …e a placeholder.
    Rebecca Stevens committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    bf46922 View commit details
    Browse the repository at this point in the history

  3. Removed unneeded data object wraps.

    Rebecca Stevens committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    a1a5a66 View commit details
    Browse the repository at this point in the history

  4. Tasks no longer have data associated with them.

    Rebecca Stevens committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    35d3d26 View commit details
    Browse the repository at this point in the history

  5. Moved 'isLast' into function loop to mimic original for loop scoping.

    Rebecca Stevens committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    d8613ad View commit details
    Browse the repository at this point in the history

  6. Slight code style improvements.

    Rebecca Stevens committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    bb191cf View commit details
    Browse the repository at this point in the history

  7. Added missing callbacks.

    Rebecca Stevens committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    29c71ea View commit details
    Browse the repository at this point in the history

  8. Fixed bad implementation of cleanConditionalComment callback support.

    Rebecca Stevens committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    d6b2bf3 View commit details
    Browse the repository at this point in the history

  9. Removed already fixed fixme.

    Rebecca Stevens committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    0316fb9 View commit details
    Browse the repository at this point in the history

  10. Fixed issue with minifyCSS and minifyJS functions taking an error in … 

    …their callback.
    Rebecca Stevens committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    818f20a View commit details
    Browse the repository at this point in the history

  11. Added async tests.

    Rebecca Stevens committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    58d6d42 View commit details
    Browse the repository at this point in the history

  12. Fixed up tests.

    Rebecca Stevens committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    58ca98e View commit details
    Browse the repository at this point in the history

  13. Added 'callback called multiple times' tests.

    Rebecca Stevens committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    8e4351d View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2018

  1. Fixed bad test 'callback called multiple times' and got it passing.

    @RebeccaStevens
    RebeccaStevens committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    5961a66 View commit details
    Browse the repository at this point in the history

  2. Fixed bug in tests causing them to throw errors.

    @RebeccaStevens
    RebeccaStevens committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    adad665 View commit details
    Browse the repository at this point in the history

  3. Fixed up tests.

    @RebeccaStevens
    RebeccaStevens committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    f57abf3 View commit details
    Browse the repository at this point in the history

  4. Fixed up jsdoc.

    @RebeccaStevens
    RebeccaStevens committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    587da38 View commit details
    Browse the repository at this point in the history

  5. Increased timout.

    @RebeccaStevens
    RebeccaStevens committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    9addaf6 View commit details
    Browse the repository at this point in the history

  6. Made the test_minify_async_error consistent with test_minify_sync_error

    @RebeccaStevens
    RebeccaStevens committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    99d8546 View commit details
    Browse the repository at this point in the history

  7. Fixed up jsdoc types.

    @RebeccaStevens
    RebeccaStevens committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    3552c4e View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2018

  1. Merged async and sync test functions togetehr.

    @RebeccaStevens
    RebeccaStevens committed Apr 24, 2018
    Configuration menu
    Copy the full SHA
    31edf01 View commit details
    Browse the repository at this point in the history

  2. Refactored.

    @RebeccaStevens
    RebeccaStevens committed Apr 24, 2018
    Configuration menu
    Copy the full SHA
    1a1edc5 View commit details
    Browse the repository at this point in the history

  3. Added safety checks and fix bad test.

    @RebeccaStevens
    RebeccaStevens committed Apr 24, 2018
    Configuration menu
    Copy the full SHA
    61e5cd9 View commit details
    Browse the repository at this point in the history

  4. Switch out assert.throws with test_minify_error

    @RebeccaStevens
    RebeccaStevens committed Apr 24, 2018
    Configuration menu
    Copy the full SHA
    7ef92b4 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2018

  1. Removed async only option from test_minify.

    Rebecca Stevens committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    b17b970 View commit details
    Browse the repository at this point in the history

  2. Refactored Task and TaskGroup.

    Rebecca Stevens committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    fcd3c59 View commit details
    Browse the repository at this point in the history

  3. Fix issue with not all callbacks being in the form of (error, result).

    Rebecca Stevens committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    a2968a0 View commit details
    Browse the repository at this point in the history

  4. Moved typedefs below imports.

    Rebecca Stevens committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    f9dee3c View commit details
    Browse the repository at this point in the history

  5. Fixed 'Maximum call stack size exceeded' in the sync case.

    Rebecca Stevens committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    675d086 View commit details
    Browse the repository at this point in the history

  6. Removed sync callback tests. Callbacks are never sync now.

    Rebecca Stevens committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    aef9258 View commit details
    Browse the repository at this point in the history

  7. Fixed 'Maximum call stack size exceeded' in the async case.

    Rebecca Stevens committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    e8c9048 View commit details
    Browse the repository at this point in the history

  8. Improved comment.

    Rebecca Stevens committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    c39b07a View commit details
    Browse the repository at this point in the history

  9. Recovered from 'Maximum call stack size exceeded' error.

    Rebecca Stevens committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    38a147d View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2018

  1. Refactored

    Rebecca Stevens committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    8767828 View commit details
    Browse the repository at this point in the history

  2. The buffer can now recover from 'Maximum call stack size exceeded' er… 

    …ror.
    Rebecca Stevens committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    955882a View commit details
    Browse the repository at this point in the history