feat(init): install coffee-script automatically #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -255,12 +255,17 @@ exports.init = function(config) { | |||
| sm.process(questions, function(answers) { | |||
| var cwd = process.cwd(); | |||
| var configFile = config.configFile || 'karma.conf.js'; | |||
| var testMainFile = (/\.coffee$/).test(configFile) ? 'test-main.coffee' : 'test-main.js'; | |||
| var isCoffee = (/\.coffee/).test(configFile); | |||
There was a problem hiding this comment.
Why you remove $ from RegExp?)
There was a problem hiding this comment.
Good catch @maksimr. I put it back
|
LGTM |
| @@ -255,12 +255,17 @@ exports.init = function(config) { | |||
| sm.process(questions, function(answers) { | |||
| var cwd = process.cwd(); | |||
| var configFile = config.configFile || 'karma.conf.js'; | |||
| var testMainFile = (/\.coffee$/).test(configFile) ? 'test-main.coffee' : 'test-main.js'; | |||
| var isCoffee = (/\.coffee$/).test(configFile); | |||
There was a problem hiding this comment.
Hey, have you gave a look to path.extname?
There was a problem hiding this comment.
This is cool! Haven't heard about this one before.
I'm going to update this PR later today.
Thanks, @aymericbeaumet
if the user initialize Karma passing a .coffee file we'll install coffee-script and put it as a dev-dependency Closes karma-runner#1152
|
LGTM |
maksimr
added a commit
that referenced
this pull request
Aug 21, 2014
feat(init): install coffee-script automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the user initialize Karma passing a .coffee file we'll install
coffee-script and put it as a dev-dependency
Closes #1152