Directory Listing: Add UTF-8 Charset to the response Content type #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within the directory listing handler, the absence of an explicit charset in the content type has led to issues, particularly with directories containing non-ASCII symbols, resulting in broken displays. Adding charset charset=UTF-8 to the Content-type header fixes this issue.
straight-shoota
approved these changes
Apr 28, 2024
|
Seams like this part of code is a monkey patched crystal std lib. |
Sija
added a commit
to Sija/kemal
that referenced
this pull request
May 7, 2024
sdogruyol
pushed a commit
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the directory listing handler, the absence of an explicit charset in the content type has led to issues, particularly with directories containing non-ASCII symbols, resulting in broken displays.
Adding charset charset=UTF-8 to the Content-type header fixes this issue.
Alternate Designs
<meta charset="UTF-8">to https://github.com/crystal-lang/crystal/blob/master/src/http/server/handlers/static_file_handler.htmlserve_staticconfigBenefits
it works
Possible Drawbacks
Not flexible for non UTF-8 cases.