-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the test runner url to the email report #223
base: main
Are you sure you want to change the base?
Conversation
10bd551
to
899755b
Compare
To be able to add the test runner url (ex: Jenkins url) to the email report, we had to add it first to the test group data base and then use the field in the email report Signed-off-by: Khouloud Touil <ktouil@baylibre.com>
899755b
to
d9bd221
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm not sure if "test_runner_url" is the best name, but it's better and more generic than "jenkins_url" since jenkins is not a requirement.
@gctucker any opinions on the name here?
Hello, @gctucker please can you have a look on this PR ? |
@gctucker ping for opinions on naming. |
To be honest, I don't understand what this is all about. What do you call a test runner? I don't see how a Jenkins URL could be useful to anyone except KernelCI admins so I think I'm missing some context here. |
It's useful for KernelCI admins, but also anyone working on their own instance of KernelCI and wanting to be able to work backwards in the pipeline from a failed build to the original "test runner" (e.g. Jenkins job.) For example, for AGL, we would like to do a modified email report templated, and they would like this URL in the email reports. This is particularily useful for those just being introduced to KernelCI. They may be already familiar with their jenkins pipeline, so having a link back to Jenkins will greatly help developer debug. |
OK, I see. "Test runner" sounds be a bit ambiguous though, as it can easily be mixed up with a device running the tests such as board in a LAVA lab or a VM somewhere. Maybe orchestration would be a better word. We shouldn't have this link appearing to general email reports, and I see it is optional so that should be fine. It would be good to have at least one test run with this URL set on staging to test it actually works end-to-end once. |
To be able to add the test runner url (ex: Jenkins url) to the email
report, we had to add it first to the test group data base and then
use the field in the email report
Signed-off-by: Khouloud Touil ktouil@baylibre.com