OOPS - forget this, Kevin: Zone Change handling #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msgData for ZC messages now has zone and zoneStatus attributes. zoneStatus values are from p53 of ELK-M1_R232_Protocol document.
# Conflicts: # lib/parser.js # lib/protocol.js
caseyd
changed the title
|
I got out of 'sync' - I made zone change handlers a couple of years ago, but didn't doublecheck here before doing the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Kevin,
NEVER MIND - you made these changes!
I've made some simple changes for handling Zone Changes coming from the Elk. I'm not a node programmer really, so if there are some style issues let me know.