First refactorings towards overrideable smell detectors

lib/reek/smells/smell_detector.rb

@@ -34,8 +34,12 @@ def self.default_config
         }
       end
 
+      def self.create(config)
+        new(config[class_name])
+      end
+
       def self.listen(hooks, config)
-        detector = new(config[class_name])
+        detector = create(config)
         contexts.each { |ctx| hooks[ctx] << detector }
         detector
       end
@@ -51,6 +55,20 @@ def be_masked
         @masked = true
       end
 
+      def enabled?
+        @enabled
+      end
+
+      def configure(config)
+        my_part = config[self.class.name.split(/::/)[-1]]
+        return unless my_part
+        configure_with(my_part)
+      end
+
+      def configure_with(config)
+        @enabled = config[ENABLED_KEY]  # if config.has_key?(ENABLED_KEY)
+      end
+
       def examine(context)
         before = @smells_found.size
         examine_context(context) if @enabled and !exception?(context)

spec/reek/smells/smell_detector_spec.rb

@@ -2,6 +2,7 @@
 
 require 'reek/report'
 require 'reek/smells/duplication'
+require 'reek/smells/large_class'
 
 include Reek
 include Reek::Smells
@@ -21,3 +22,18 @@
   end
 end
 
+describe SmellDetector, 'configuration' do
+#  it 'stays enabled when not disabled' do
+#    @detector = LargeClass.new
+#    @detector.should be_enabled
+#    @detector.configure({'LargeClass' => {'max_methods' => 50}})
+#    @detector.should be_enabled
+#  end
+
+  it 'becomes disabled when disabled' do
+    @detector = LargeClass.new
+    @detector.should be_enabled
+    @detector.configure({'LargeClass' => {'enabled' => false}})
+    @detector.should_not be_enabled
+  end
+end

tasks/build.rake

@@ -1,3 +1,4 @@
+require 'rubygems'
 
 namespace :build do
   Rake::GemPackageTask.new($gemspec) do |task|