Removed some unnecessary attr_readers

kevinrutherford · Mar 25, 2009 · 6e092e6 · 6e092e6
1 parent 211822c
commit 6e092e6
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 13 deletions.
diff --git a/lib/reek/block_context.rb b/lib/reek/block_context.rb
@@ -2,7 +2,6 @@
 
 module Reek
   class BlockContext < CodeContext
-    attr_reader :parameters, :local_variables
 
     def initialize(outer, exp)
       super
@@ -15,8 +14,8 @@ def inside_a_block?
       true
     end
 
-    def has_parameter(sym)
-      parameters.include?(sym) or @outer.has_parameter(sym)
+    def has_parameter(name)
+      @parameters.include?(name) or @outer.has_parameter(name)
     end
 
     def nested_block?

diff --git a/lib/reek/class_context.rb b/lib/reek/class_context.rb
@@ -18,8 +18,6 @@ def ClassContext.create(outer, exp)
       ClassContext.new(res[0], res[1], exp[2])
     end
 
-    attr_accessor :name
-
     def initialize(outer, name, superclass = nil)
       super(outer, nil)
       @name = name

diff --git a/lib/reek/code_context.rb b/lib/reek/code_context.rb
@@ -7,7 +7,7 @@ module Reek
   # with each context holding a reference to a unique outer context.
   #
   class CodeContext
-    attr_reader :outer
+
     attr_reader :name
 
     def initialize(outer, exp)

diff --git a/lib/reek/method_context.rb b/lib/reek/method_context.rb
@@ -4,10 +4,10 @@
 
 module Reek
   class MethodContext < CodeContext
-    attr_reader :parameters, :local_variables
-    attr_reader :calls, :refs
-    attr_reader :num_statements, :depends_on_self
-    attr_accessor :name
+    attr_reader :parameters
+    attr_reader :calls
+    attr_reader :refs
+    attr_reader :num_statements
 
     def initialize(outer, exp, record = true)
       super(outer, exp)
@@ -30,7 +30,7 @@ def depends_on_instance?
     end
 
     def has_parameter(sym)
-      parameters.include?(sym.to_s)
+      @parameters.include?(sym.to_s)
     end
 
     def record_call_to(exp)

diff --git a/spec/reek/method_context_spec.rb b/spec/reek/method_context_spec.rb
@@ -45,8 +45,8 @@
 describe MethodContext do
   it 'should record ivars as refs to self' do
     mctx = MethodContext.new(StopContext.new, [:defn, :feed])
-    mctx.refs.refs_to_self.should == 1
+    mctx.envious_receivers.should == []
     mctx.record_call_to([:call, [:ivar, :@cow], :feed_to])
-    mctx.refs.refs_to_self.should == 2
+    mctx.envious_receivers.should == []
   end
 end