Skip to content

Commit

Permalink
Ensured the specs run independently
Browse files Browse the repository at this point in the history
  • Loading branch information
kevinrutherford committed Mar 31, 2009
1 parent c07afd2 commit 8329312
Show file tree
Hide file tree
Showing 10 changed files with 30 additions and 16 deletions.
2 changes: 2 additions & 0 deletions lib/reek/source.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
require 'reek/code_parser'
require 'reek/report'
require 'reek/smells/smells'

module Reek

Expand Down
2 changes: 2 additions & 0 deletions spec/reek/class_context_spec.rb
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
require File.dirname(__FILE__) + '/../spec_helper.rb'

require 'reek/class_context'
require 'reek/stop_context'
require 'reek/smells/feature_envy'

include Reek
include Reek::Smells

describe ClassContext do
it 'should report Long Parameter List' do
Expand Down
2 changes: 2 additions & 0 deletions spec/reek/module_context_spec.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
require File.dirname(__FILE__) + '/../spec_helper.rb'
require 'reek/module_context'
require 'reek/stop_context'

include Reek

Expand Down
5 changes: 3 additions & 2 deletions spec/reek/report_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
require 'reek/smells/smell_detector'
require 'reek/report'
require 'reek/source'
require 'reek/smells/feature_envy'

include Reek

Expand Down Expand Up @@ -39,9 +40,9 @@
describe Report, " as a SortedSet" do
it 'should only add a smell once' do
rpt = Report.new
rpt << SmellWarning.new(FeatureEnvy.new, "self", 'too many!')
rpt << SmellWarning.new(Smells::FeatureEnvy.new, "self", 'too many!')
rpt.length.should == 1
rpt << SmellWarning.new(FeatureEnvy.new, "self", 'too many!')
rpt << SmellWarning.new(Smells::FeatureEnvy.new, "self", 'too many!')
rpt.length.should == 1
end
end
5 changes: 5 additions & 0 deletions spec/reek/smells/duplication_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
require File.dirname(__FILE__) + '/../../spec_helper.rb'
require 'reek/report'
require 'reek/method_context'
require 'reek/stop_context'
require 'reek/smells/duplication'

include Reek
include Reek::Smells

describe Duplication, "repeated method calls" do
Expand Down
2 changes: 1 addition & 1 deletion spec/reek/smells/feature_envy_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
require File.dirname(__FILE__) + '/../../spec_helper.rb'
require 'reek/smells/feature_envy'

require 'reek/method_context'
require 'reek/stop_context'

Expand Down
1 change: 1 addition & 0 deletions spec/reek/smells/large_class_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
require File.dirname(__FILE__) + '/../../spec_helper.rb'
require 'reek/code_parser'
require 'reek/report'
require 'reek/smells/large_class'
Expand Down
4 changes: 2 additions & 2 deletions spec/reek/smells/smell_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@

describe SmellWarning, ' in comparisons' do
before :each do
@first = SmellWarning.new(FeatureEnvy.new, "self", "self")
@second = SmellWarning.new(FeatureEnvy.new, "self", "self")
@first = SmellWarning.new(Smells::FeatureEnvy.new, "self", "self")
@second = SmellWarning.new(Smells::FeatureEnvy.new, "self", "self")
end

it 'should hash equal when the smell is the same' do
Expand Down
22 changes: 12 additions & 10 deletions spec/reek/smells/uncommunicative_name_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
require File.dirname(__FILE__) + '/../../spec_helper.rb'
require 'ostruct'
require 'reek/method_context'
require 'reek/smells/uncommunicative_name'

include Reek
include Reek::Smells

describe CodeParser, "uncommunicative method name" do
describe UncommunicativeName, "method name" do
it 'should not report one-word method name' do
'def help(fred) basics(17) end'.should_not reek
end
Expand All @@ -12,7 +18,7 @@
end
end

describe CodeParser, "uncommunicative field name" do
describe UncommunicativeName, "field name" do
it 'should not report one-word field name' do
'class Thing; def help(fred) @simple end end'.should_not reek
end
Expand All @@ -27,7 +33,7 @@
end
end

describe CodeParser, "uncommunicative local variable name" do
describe UncommunicativeName, "local variable name" do
it 'should not report one-word variable name' do
'def help(fred) simple = jim(45) end'.should_not reek
end
Expand All @@ -42,7 +48,7 @@
end
end

describe CodeParser, "uncommunicative parameter name" do
describe UncommunicativeName, "parameter name" do
it 'should not recognise *' do
'def help(xray, *) basics(17) end'.should_not reek
end
Expand All @@ -54,7 +60,7 @@
end
end

describe CodeParser, "uncommunicative block parameter name" do
describe UncommunicativeName, "block parameter name" do
it "should report parameter's name" do
'def help() @stuff.each {|x|} end'.should reek_only_of(:UncommunicativeName, /x/, /block/, /variable name/)
end
Expand All @@ -71,7 +77,7 @@ def bad
end
end

describe CodeParser, "several uncommunicative names" do
describe UncommunicativeName, "several names" do

it 'should report all bad names' do
ruby = Source.from_s('class Oof; def y(x) @z = x end end')
Expand All @@ -94,10 +100,6 @@ def bad(fred)
end
end

require 'ostruct'
require 'reek/smells/uncommunicative_name'
include Reek::Smells

describe UncommunicativeName, '#examine' do
before :each do
@report = Report.new
Expand Down
1 change: 0 additions & 1 deletion spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
require 'spec'
end

require 'reek'
require 'reek/spec'

Spec::Runner.configure do |config|
Expand Down

0 comments on commit 8329312

Please sign in to comment.