@@ -1,11 +1,8 @@ --- LargeClass: max_methods: 25 - exclude: - - Array - - Hash - - Module - - String + exclude: [] + enabled: true max_instance_variables: 9 LongParameterList: config/defaults.reek @@ -2,10 +2,6 @@ require 'set' require 'reek/code_context' class Class - def non_inherited_methods - instance_methods(false) + private_instance_methods(false) - end - def is_overriding_method?(sym) instance_methods(false).include?(sym) and superclass.instance_methods(true).include?(sym) end @@ -47,8 +43,7 @@ module Reek end def num_methods - meths = myself ? @myself.non_inherited_methods : @parsed_methods - meths.length + @parsed_methods.length end def record_instance_variable(sym) lib/reek/class_context.rb @@ -32,7 +32,7 @@ module Reek super.adopt( MAX_ALLOWED_METHODS_KEY => 25, MAX_ALLOWED_IVARS_KEY => 9, - EXCLUDE_KEY => ['Array', 'Hash', 'Module', 'String'] + EXCLUDE_KEY => [] ) end lib/reek/smells/large_class.rb @@ -39,46 +39,6 @@ EOEX end end -describe Class do - - module Insert - def meth_a() end - private - def meth_b() end - protected - def meth_c() end - end - - class Parent - def meth1() end - private - def meth2() end - protected - def meth3() end - end - - class FullChild < Parent - include Insert - def meth7() end - private - def meth8() end - protected - def meth6() end - end - - describe 'with no superclass or modules' do - it 'should report correct number of methods' do - Parent.non_inherited_methods.length.should == 3 - end - end - - describe 'with superclass and modules' do - it 'should report correct number of methods' do - FullChild.non_inherited_methods.length.should == 3 - end - end -end - describe ClassContext, 'overridden methods' do class Above def above() end spec/reek/class_context_spec.rb @@ -21,7 +21,6 @@ describe 'sample gem source code' do ruby.should reek_of(:Duplication, /Inline::self.rootdir/, /env.nil?/) ruby.should reek_of(:Duplication, /Module#inline/, /Inline.const_get\(lang\)/) ruby.should reek_of(:FeatureEnvy, /Inline::C#strip_comments/, /src/) - ruby.should reek_of(:LargeClass, /Inline::C/, /methods/) ruby.should reek_of(:LargeClass, /Inline::C/, /instance variables/) ruby.should reek_of(:LongMethod, /File#self.write_with_backup/) ruby.should reek_of(:LongMethod, /Inline::C#build/) @@ -39,6 +38,6 @@ describe 'sample gem source code' do ruby.should reek_of(:UncommunicativeName, /Inline::C#module_name/, /'x'/) ruby.should reek_of(:UncommunicativeName, /Inline::C#parse_signature/, /'x'/) ruby.should reek_of(:UtilityFunction, /Inline::C#strip_comments/) - ruby.report.should have_at_most(36).smells + ruby.report.should have_at_most(35).smells end end spec/slow/inline_spec.rb @@ -104,7 +104,7 @@ class ::Rake::SshDirPublisher attr_reader :host, :remote_dir, :local_dir end -file GEMSPEC => [GEM_MANIFEST, VERSION_FILE, __FILE__] do +file GEMSPEC => [GEM_MANIFEST, HISTORY_FILE, VERSION_FILE, __FILE__] do GEMSPEC.touch($gemspec.to_ruby) end tasks/deployment.rake d4dfc7011e8461678fe6917f78959e3abae57e48 Kevin Rutherford kevin@rutherford-software.com http://github.com/kevinrutherford/reek/commit/e235ca966ec45a49991a55ecd744977caa9dedf3 e235ca966ec45a49991a55ecd744977caa9dedf3 2009-05-18T12:23:13-07:00 2009-05-18T12:23:13-07:00 LargeClass no longer counts methods from the loaded class 97dcba69e9f113d929dd6117f5ff103305163e18 Kevin Rutherford kevin@rutherford-software.com