forked from troessner/reek
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Removed the redundant blank line between reports
- Loading branch information
1 parent
0783106
commit e64391f
Showing
5 changed files
with
52 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
@rake | ||
Feature: RakeTask | ||
In order to run reek as part of my CI process | ||
As a developer | ||
I want to create rake tasks to run reek | ||
|
||
Scenario: reports no smells in reek's own source code | ||
When I run rake reek | ||
Then it succeeds |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
@reports | ||
Feature: Correclty formatted reports | ||
In order to get the most out of reek | ||
As a developer | ||
I want to be able to parse reek's output simply and consistently | ||
|
||
Scenario: two reports run together with indented smells | ||
When I run reek spec/samples/two_smelly_files/*.rb | ||
Then it fails with exit status 2 | ||
And it reports: | ||
""" | ||
spec/samples/two_smelly_files/dirty_one.rb -- 6 warnings: | ||
Dirty has the variable name '@s' (Uncommunicative Name) | ||
Dirty#a calls @s.title multiple times (Duplication) | ||
Dirty#a calls puts(@s.title) multiple times (Duplication) | ||
Dirty#a has the name 'a' (Uncommunicative Name) | ||
Dirty#a/block has the variable name 'x' (Uncommunicative Name) | ||
Dirty#a/block/block is nested (Nested Iterators) | ||
spec/samples/two_smelly_files/dirty_two.rb -- 6 warnings: | ||
Dirty has the variable name '@s' (Uncommunicative Name) | ||
Dirty#a calls @s.title multiple times (Duplication) | ||
Dirty#a calls puts(@s.title) multiple times (Duplication) | ||
Dirty#a has the name 'a' (Uncommunicative Name) | ||
Dirty#a/block has the variable name 'x' (Uncommunicative Name) | ||
Dirty#a/block/block is nested (Nested Iterators) | ||
""" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
class Dirty | ||
def a | ||
puts @s.title | ||
@s.map {|x| x.each {|key| key += 3}} | ||
puts @s.title | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
class Dirty | ||
def a | ||
puts @s.title | ||
@s.map {|x| x.each {|key| key += 3}} | ||
puts @s.title | ||
end | ||
end |