Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VULNERABILITY] Parsing a long String will result in 100% CPU usage and String.test will never finish #72

Closed
wants to merge 1 commit into from

Conversation

ChengpeiShi
Copy link

As @niftylettuce mentioned in #70
This PR update to use node-re2 to fix a very long string can cause a Denial of Service.

@Richienb
Copy link

This breaks browser support since it uses native modules.

@niftylettuce
Copy link
Collaborator

This issue is fixed in my maintained and modern version of this package at https://github.com/niftylettuce/url-regex-safe. You should be able to switch from url-regex to url-regex-safe now. See the updated list of options as I added some new ones, and changed a few defaults to more sensible ones (since not everyone is parsing Markdown for instance).

@ChengpeiShi ChengpeiShi closed this Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants