Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Account Console version 2 #27510

Merged
merged 1 commit into from Mar 27, 2024
Merged

Conversation

jonkoops
Copy link
Contributor

@jonkoops jonkoops commented Mar 4, 2024

Removes the source code for the Account Console version 2 and fixes up any code that still relied on this feature. This PR does not include release notes, or removal of now dead testing code, which will be handled in a separate PR.

Closes #19664

@jonkoops jonkoops self-assigned this Mar 4, 2024
@jonkoops jonkoops force-pushed the rm-account-v2 branch 2 times, most recently from 38f3392 to 8e18889 Compare March 4, 2024 17:09
@jonkoops jonkoops added the status/hold PR should not be merged. On hold for later. label Mar 4, 2024
@jonkoops jonkoops force-pushed the rm-account-v2 branch 2 times, most recently from b1af160 to 28ac71c Compare March 4, 2024 17:52
@jonkoops jonkoops force-pushed the rm-account-v2 branch 2 times, most recently from 4130daa to 479dab4 Compare March 26, 2024 16:49
Closes keycloak#19664

Signed-off-by: Jon Koops <jonkoops@gmail.com>
keycloak-github-bot[bot]

This comment was marked as off-topic.

Copy link
Contributor

@agagancarczyk agagancarczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and approving also based on previous approvals. Not merging it yet in case additional UI team members want to review it.

@jonkoops jonkoops merged commit 3382e16 into keycloak:main Mar 27, 2024
68 checks passed
@jonkoops jonkoops deleted the rm-account-v2 branch March 27, 2024 09:53
hmlnarik added a commit to hmlnarik/keycloak that referenced this pull request Apr 17, 2024
Follows-up: keycloak#27510

Signed-off-by: Hynek Mlnarik <hmlnarik@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Account Console v2
4 participants