User Profile translations - value put in correct field after search #28047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agagancarczyk
force-pushed
the
issue-27838
branch
2 times, most recently
from
c80da6e
to
c97e615
Compare
jonkoops
requested changes
Mar 20, 2024
Comment on lines
89
to
90
| (attribute: UserProfileAttribute) => | ||
| attribute.name === attributeToDelete, |
There was a problem hiding this comment.
This type is already inferrable, let's not add any additional type information if it's not needed.
Suggested change
| (attribute: UserProfileAttribute) => | |
| attribute.name === attributeToDelete, | |
| (attribute) => attribute.name === attributeToDelete, |
| )?.displayName; | ||
|
|
||
| const formattedTranslationsToDelete = translationsToDelete?.substring( |
There was a problem hiding this comment.
Could you add a comment here with some explanation as to why we need to slice this string like this?
Comment on lines
129
to
130
| (attribute: UserProfileAttribute) => | ||
| attribute.name !== attributeToDelete, |
There was a problem hiding this comment.
Same here, type can be inferred.
Suggested change
| (attribute: UserProfileAttribute) => | |
| attribute.name !== attributeToDelete, | |
| (attribute) => attribute.name !== attributeToDelete, |
| @@ -116,11 +116,32 @@ export const AddTranslationsDialog = ({ | |||
| }, [combinedLocales, translationKey, setValue]); | |||
|
|
|||
| const handleOk = () => { | |||
| const formData = getValues(); | |||
| onTranslationsAdded(formData); | |||
| const formData = getValues() as Translations; | |||
There was a problem hiding this comment.
Looks like this compiles the same without a type-cast, so let's remove it.
Suggested change
| const formData = getValues() as Translations; | |
| const formData = getValues(); |
| whoAmI.getLocale(), | ||
| )} | ||
| {filteredLocales.map((locale) => { | ||
| const rowIndex = combinedLocales.findIndex( |
There was a problem hiding this comment.
Are you sure rowIndex is always unique? It's being used as a key here, which can lead to issues if not unique in this loop.
There was a problem hiding this comment.
Thanks @jonkoops I have added the index provided by the map(), and I'm using it as a fallback to ensure the uniqueness of the key.
Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com>
Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com>
Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com>
agagancarczyk
force-pushed
the
issue-27838
branch
from
c97e615
to
0a08a5c
Compare
jonkoops
approved these changes
Mar 21, 2024
ahus1
pushed a commit
to ahus1/keycloak
that referenced
this pull request
Mar 22, 2024
…eycloak#28047) * fixed the issue of adding translation for searched locale Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com> * fixed the issue of adding translation for searched locale Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com> * small fix Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com> * renamed Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com> * fixed translation deleting on attribute deletion Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com> * feedback Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com> --------- Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com> Co-authored-by: Agnieszka Gancarczyk <agancarc@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27838 and closes #28103