added "on" label to checkbox #28087
Merged
added "on" label to checkbox #28087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
jonkoops
approved these changes
Mar 20, 2024
| @@ -25,7 +33,7 @@ export const OptionComponent = (props: UserProfileFieldProps) => { | |||
| key={option} | |||
| id={option} | |||
| data-testid={option} | |||
| label={option} | |||
| label={props.t(unWrap(optionLabel?.on || option))} | |||
There was a problem hiding this comment.
Do we need to unWrap(label) here as well, or can we get away with:
Suggested change
| label={props.t(unWrap(optionLabel?.on || option))} | |
| label={props.t(optionLabel?.on ? unWrap(optionLabel.on) : option)} |
There was a problem hiding this comment.
No, it can be a translation key, see the issue
ahus1
pushed a commit
to ahus1/keycloak
that referenced
this pull request
Mar 22, 2024
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
lme-atolcd
reviewed
Mar 25, 2024
| @@ -25,7 +33,7 @@ export const OptionComponent = (props: UserProfileFieldProps) => { | |||
| key={option} | |||
| id={option} | |||
| data-testid={option} | |||
| label={option} | |||
| label={props.t(unWrap(optionLabel?.on || option))} | |||
There was a problem hiding this comment.
It seems that using optionLabel?.on will look for a entry in inputOptionLabels for the key "on". My guess is that this should rather look for the key option.
Suggestion:
label={props.t(unWrap(optionLabel?.[option] || option))}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #28078
Signed-off-by: Erik Jan de Wit erikjan.dewit@gmail.com