Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidating offline token is not working from client sessions tab #28101

Merged

Conversation

martin-kanis
Copy link
Contributor

Closes #27275

Comment on lines +208 to +209
rowData.data.type === "Offline" ||
rowData.data.type === "OFFLINE"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have two similar types here? This seems like an issue with the data provided, can it not be normalized in the REST API, or even the database?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an inconsistency how sessions are obtained on sessions page and on clients/{clientid}/sessions page. As a result there are different sessions types. Created #28124
For this PR, I had to work with what we have at place ATM as this needs to be ready for 24 backport ASAP.

Copy link
Contributor

@pedroigor pedroigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we need to differentiate in-memory and offline sessions when deleting sessions but not a blocker.

Closes keycloak#27275

Signed-off-by: Martin Kanis <mkanis@redhat.com>
@pedroigor pedroigor force-pushed the 27275-logout-offline-session-from-ui branch from 017bce8 to af2f1a8 Compare March 21, 2024 10:55
@pedroigor pedroigor enabled auto-merge (rebase) March 21, 2024 11:31
@pedroigor pedroigor merged commit 4154d27 into keycloak:main Mar 21, 2024
73 of 120 checks passed
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.admin.concurrency.ConcurrencyTest#createClient

Keycloak CI - Base IT (1)

java.lang.RuntimeException: There were failures in threads. Failures count: 1
	at org.keycloak.testsuite.admin.concurrency.AbstractConcurrencyTest.run(AbstractConcurrencyTest.java:122)
	at org.keycloak.testsuite.admin.concurrency.AbstractConcurrencyTest.run(AbstractConcurrencyTest.java:63)
	at org.keycloak.testsuite.admin.concurrency.AbstractConcurrencyTest.run(AbstractConcurrencyTest.java:59)
	at org.keycloak.testsuite.admin.concurrency.ConcurrencyTest.concurrentTest(ConcurrencyTest.java:61)
...

Report flaky test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalidating offline token is not working from client sessions tab
3 participants