New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalidating offline token is not working from client sessions tab #28101
Invalidating offline token is not working from client sessions tab #28101
Conversation
b9e34a0
to
b810416
Compare
rowData.data.type === "Offline" || | ||
rowData.data.type === "OFFLINE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have two similar types here? This seems like an issue with the data provided, can it not be normalized in the REST API, or even the database?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an inconsistency how sessions are obtained on sessions
page and on clients/{clientid}/sessions
page. As a result there are different sessions types. Created #28124
For this PR, I had to work with what we have at place ATM as this needs to be ready for 24 backport ASAP.
b810416
to
017bce8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we need to differentiate in-memory and offline sessions when deleting sessions but not a blocker.
Closes keycloak#27275 Signed-off-by: Martin Kanis <mkanis@redhat.com>
017bce8
to
af2f1a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreported flaky test detected, please review
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.admin.concurrency.ConcurrencyTest#createClient
|
Closes #27275