Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade admin and account console to PatternFly 5 #28196

Merged
merged 1 commit into from Apr 5, 2024
Merged

Upgrade admin and account console to PatternFly 5 #28196

merged 1 commit into from Apr 5, 2024

Conversation

jonkoops
Copy link
Contributor

@jonkoops jonkoops commented Mar 25, 2024 •
edited

Closes #21345
Closes #21344

@jonkoops jonkoops requested a review from a team as a code owner March 25, 2024 11:00
@jonkoops jonkoops marked this pull request as draft March 25, 2024 11:01
@jonkoops jonkoops mentioned this pull request Mar 25, 2024
Open
@jonkoops jonkoops force-pushed the pf5 branch 13 times, most recently from c3ccf73 to c996db1 Compare March 25, 2024 17:45
edewit
edewit previously approved these changes Mar 27, 2024
View reviewed changes
This was referenced Mar 28, 2024
Open
Open
@jonkoops jonkoops mentioned this pull request Apr 2, 2024
Merged
@jonkoops jonkoops requested a review from a team as a code owner April 5, 2024 11:40
hmlnarik
hmlnarik previously approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@hmlnarik hmlnarik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job everyone!

jonkoops
jonkoops commented Apr 5, 2024
View reviewed changes
Copy link
Contributor Author

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonkoops @edewit
@mfrances17 @hmlnarik @agancarc
Upgrade admin and account console to PatternFly 5
88e49cb 
Closes keycloak#21345
Closes keycloak#21344

Co-authored-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
Co-authored-by: Mark Franceschelli <mfrances@redhat.com>
Co-authored-by: Hynek Mlnařík <hmlnarik@redhat.com>
Co-authored-by: Agnieszka Gancarczyk <agancarc@redhat.com>
Signed-off-by: Jon Koops <jonkoops@gmail.com>
This was referenced Apr 5, 2024
Open
Open
Open
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Apr 5, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.RegisterTest#registerExistingUsernameForbidden

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerUserMissingTermsAcceptance

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerUserManyErrors

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerUserSuccessWithEmailVerificationWithResend

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#testRegisterShouldFailBeforeUserCreationWhenUserIsInContext

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerUserSuccessEditUsernameDisabled

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerUserUmlats

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerUserMissingOrInvalidEmail_emailAsUsername

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerUserNotUsernamePasswordPolicy

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerUserSuccess_emailAsUsername

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerUpperCaseEmailAsUsername

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerWithLoginHint

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerUserSuccessEditUsernameEnabled

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerUserMissingEmail

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerPasswordPolicy

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerUpperCaseEmailWithChangedEmailAsUsername

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerExistingEmailAllowed

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerUserMissingUsername

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerUserSuccessWithEmailVerification

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerUserSuccessTermsAcceptance

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerUserSuccessTermsAcceptanceWithRequiredActionEnabled

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerWithLoginHint_emailAsUsername

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerUpperCaseEmail

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#testEmailAsUsernameWhenEditUserNameDisabled

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#customRegistrationPageFormTest

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerUserSuccess

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerUserNotContainsUsernamePasswordPolicy

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerUserInvalidEmail

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerExistingEmailForbidden

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerExistingUser_emailAsUsername

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerUserMissingPassword

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerUserNotEmailPasswordPolicy

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerUserInvalidPasswordConfirm

Keycloak CI - Forms IT (chrome)

java.lang.IllegalStateException: Could not start mail server smtp:localhost:3025, try to set server startup timeout > 2000 via ServerSetup.setServerStartupTimeout(timeoutInMs) or -Dgreenmail.startup.timeout
	at com.icegreen.greenmail.util.GreenMail.start(GreenMail.java:118)
	at org.keycloak.testsuite.util.GreenMailRule.before(GreenMailRule.java:54)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
	at org.jboss.arquillian.junit.Arquillian$7$1.invoke(Arquillian.java:273)
...

Report flaky test

org.keycloak.testsuite.forms.BrowserFlowTest#testAlternativeNonInteractiveExecutorInSubflow

Keycloak CI - Forms IT (firefox)

org.openqa.selenium.TimeoutException: 
Navigation timed out after 10000 ms
Build info: version: '3.14.0', revision: 'aacccce0', time: '2018-08-02T20:19:58.91Z'
System info: host: 'fv-az1116-606', ip: '10.1.0.15', os.name: 'Linux', os.arch: 'amd64', os.version: '6.5.0-1017-azure', java.version: '17.0.10'
Driver info: org.openqa.selenium.firefox.FirefoxDriver
...

Report flaky test

org.keycloak.testsuite.webauthn.AppInitiatedActionWebAuthnTest#proceedSetupWebAuthnLogoutOtherSessionsChecked

Keycloak CI - WebAuthn IT (chrome)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:307)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

org.keycloak.testsuite.webauthn.WebAuthnRegisterAndLoginTest#registerUserSuccess

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: 
type
Expected: is "LOGOUT"
     but: was "CODE_TO_TOKEN"
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
...

Report flaky test

mfrances17
mfrances17 approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@mfrances17 mfrances17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jonkoops jonkoops merged commit d3c2475 into keycloak:main Apr 5, 2024
69 checks passed
@jonkoops jonkoops deleted the pf5 branch April 5, 2024 14:37
@Eng-Fouad Eng-Fouad mentioned this pull request Apr 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot left review comments

@edewit edewit edewit approved these changes

@agagancarczyk agagancarczyk agagancarczyk approved these changes

@hmlnarik hmlnarik hmlnarik approved these changes

@mfrances17 mfrances17 mfrances17 approved these changes

@ssilvert ssilvert Awaiting requested review from ssilvert

Assignees

@jonkoops jonkoops

Labels
flaky-test team/cloud-native team/core-clients team/core-iam team/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade admin theme to PatternFly 5 Upgrade account theme to PatternFly 5
5 participants
@jonkoops @edewit @agagancarczyk @hmlnarik @mfrances17