[DNM] Multicluster - Istio Config validations #6058
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or namespace listing.
|
Test failures are because of disabled namespace loading from cache. |
|
Moving this PR outside of the project sprint, as the task goes to 'beta' version of multicluster support. |
hhovsepy
changed the title
ScriptingShrimp
added
test-add-coverage 📎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFE #5967
Subtask: #6056
Istio config list and details shows validations from remote clusters.
Added missing cluster param in several places, put default values for metrics.
One issue I noticed, when opening config pages, then going to Overview page, there were failures in loading metrics, and not all namespaces are loaded.
For this I did put 'cluster' param's value to home cluster in some places with TODO as I added more subtasks in #5618
Also disabled loading namespaces from cache, because it was loading only home cluster cache after some point.