[DO NOT MERGE] Replace JSCH library with apache mina sshd #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins do fdb |
|
There are enforcer errors about duplicated classes from jgit deps |
RishiRajAnand
force-pushed
the
sshd-upgrade
branch
from
9b576e1
to
028dbf3
Compare
|
thanks @mareknovotny for pointing this. I have addded exclusion for org.apache.sshd:sshd-osgi in org.eclipse.jgit.ssh.apache. should be fine now. |
|
jenkins do fdb |
RishiRajAnand
changed the title
|
be aware of upgrade of sshd-core to 2.7.0 in PR status - #1898 |
|
This PR #2202 was merged so is this now redundant and we can close ? @RishiRajAnand |
|
@mareknovotny the current PR was opened for a different use case. Currently, BC uses JSCH to import external projects using ssh, but jsch project has not been into active development due to which it doesnt support latest open ssh standards. This PR would only replace that area of jsch with similiar apache sshd feature. I think we can still try to get this PR merged to avoid future issue. There's still some minor work left on the PR since i see JSCH modules aren't removed from POM and code. |
|
ok, thanks @RishiRajAnand for clarification |
|
@RishiRajAnand do you know what Jira is this related? |
|
@mareknovotny AFAIK there wasn't any Jira that this PR was targetting, but we wanted to upgrade it as part of this PR kiegroup/appformer#1223. Eventually, we were able to resolve it without upgrading jsch, so the work went on hold. |
|
jenkins retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
referenced Pull Requests: (please edit the URLs of referenced pullrequests if they exist)
kiegroup/appformer#1226
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
a pull request please add comment: Jenkins retest (using this e.g. Jenkins retest this optional but no longer required)
for a full downstream build
run_fdba compile downstream build please add comment: Jenkins run cdb
a full production downstream build please add comment: Jenkins execute product fdb
an upstream build please add comment: Jenkins run upstream