BZ:1052858 - i18n is incomplete, code changes needed

(cherry picked from commit f7042cb)

kie-wb-common-screens/kie-wb-common-project-explorer/kie-wb-common-project-explorer-client/src/main/java/org/kie/workbench/common/screens/explorer/client/ExplorerPresenterImpl.java

@@ -78,10 +78,10 @@ public class ExplorerPresenterImpl implements ExplorerPresenter {
     @Inject
     protected Caller<ExplorerService> explorerService;
 
-    private final NavLink businessView = new NavLink( "Project View" );
-    private final NavLink techView = new NavLink( "Repository View" );
-    private final NavLink treeExplorer = new NavLink( "Show as Folders" );
-    private final NavLink breadcrumbExplorer = new NavLink( "Show as Links" );
+    private final NavLink businessView = new NavLink( ProjectExplorerConstants.INSTANCE.projectView() );
+    private final NavLink techView = new NavLink( ProjectExplorerConstants.INSTANCE.repositoryView() );
+    private final NavLink treeExplorer = new NavLink( ProjectExplorerConstants.INSTANCE.showAsFolders() );
+    private final NavLink breadcrumbExplorer = new NavLink( ProjectExplorerConstants.INSTANCE.showAsLinks() );
 //    private final NavLink hiddenFiles = new NavLink( "Display hidden items" );
 
     private Set<Option> options = new HashSet<Option>( Arrays.asList( Option.BUSINESS_CONTENT, Option.EXCLUDE_HIDDEN_ITEMS ) );

kie-wb-common-screens/kie-wb-common-project-explorer/kie-wb-common-project-explorer-client/src/main/java/org/kie/workbench/common/screens/explorer/client/resources/i18n/ProjectExplorerConstants.java

@@ -55,5 +55,9 @@ public interface ProjectExplorerConstants
     public String files();
 
     public String refresh();
+    public String projectView();
+    public String repositoryView();
+    public String showAsFolders();
+    public String showAsLinks();
 
 }

kie-wb-common-screens/kie-wb-common-project-explorer/kie-wb-common-project-explorer-client/src/main/resources/org/kie/workbench/common/screens/explorer/client/resources/i18n/ProjectExplorerConstants.properties

@@ -27,3 +27,7 @@ projectColon=Project:
 packageColon=Package:
 files=Files
 refresh=Refresh
+projectView=Project View
+repositoryView=Repository View
+showAsFolders=Show as Folders
+showAsLinks=Show as Links

kie-wb-common-screens/kie-wb-common-project-explorer/kie-wb-common-project-explorer-client/src/main/resources/org/kie/workbench/common/screens/explorer/client/resources/i18n/ProjectExplorerConstants_es.properties

@@ -12,3 +12,7 @@ projectColon=Proyecto\:
 packageColon=Paquete\:
 files=Archivos
 refresh=Refrescar
+projectView=Vista de proyecto
+repositoryView=Vista de repositorio
+showAsFolders=Mostrar como carpetas
+showAsLinks=Mostrar como enlaces

kie-wb-common-widgets/kie-wb-common-ui/src/main/java/org/kie/workbench/common/widgets/client/handlers/NewResourceView.ui.xml

@@ -16,7 +16,8 @@
 <!DOCTYPE ui:UiBinder SYSTEM "http://dl.google.com/gwt/DTD/xhtml.ent">
 <ui:UiBinder xmlns:ui="urn:ui:com.google.gwt.uibinder"
              xmlns:g="urn:import:com.google.gwt.user.client.ui"
-             xmlns:b="urn:import:com.github.gwtbootstrap.client.ui">
+             xmlns:b="urn:import:com.github.gwtbootstrap.client.ui"
+             xmlns:base="urn:import:com.github.gwtbootstrap.client.ui.base">
 
   <ui:with field="i18n" type="org.kie.workbench.common.widgets.client.resources.i18n.NewItemPopupConstants"/>
   <ui:with field="i18nCommon" type="org.kie.workbench.common.widgets.client.resources.i18n.CommonConstants"/>
@@ -31,17 +32,17 @@
       <b:ControlGroup ui:field="fileNameGroup">
         <b:ControlLabel for="fileName">
           <font color="red">*</font>
-          Resource Name
+            <base:InlineLabel text="{i18n.resourceName}"/>
         </b:ControlLabel>
         <b:Controls>
-          <b:TextBox b:id="fileName" ui:field="fileNameTextBox" placeholder="resource name..."/>
+          <b:TextBox b:id="fileName" ui:field="fileNameTextBox" placeholder="{i18n.resourceNamePlaceholder}"/>
           <b:HelpInline ui:field="fileNameHelpInline"/>
         </b:Controls>
       </b:ControlGroup>
 
       <b:ControlGroup>
           <b:ControlLabel>
-          Location
+              <base:InlineLabel text="{i18n.location}"/>
         </b:ControlLabel>
         <b:Controls addStyleNames="readonly">
             <g:VerticalPanel ui:field="handlerExtensions"/>

kie-wb-common-widgets/kie-wb-common-ui/src/main/java/org/kie/workbench/common/widgets/client/resources/i18n/NewItemPopupConstants.java

@@ -34,4 +34,10 @@ public interface NewItemPopupConstants
 
     String fileNameIsMandatory();
 
+    String resourceName();
+
+    String location();
+
+    String resourceNamePlaceholder();
+
 }

kie-wb-common-widgets/kie-wb-common-ui/src/main/resources/org/kie/workbench/common/widgets/client/resources/i18n/NewItemPopupConstants.properties

@@ -1,4 +1,7 @@
 popupTitle=Create new
 itemNameSubheading=Name:
 fileNameIsMandatory=Missing name for new resource. Please enter.
+resourceName=Resource Name
+location=Location
+resourceNamePlaceholder=resource name...
 

kie-wb-common-widgets/kie-wb-common-ui/src/main/resources/org/kie/workbench/common/widgets/client/resources/i18n/NewItemPopupConstants_es.properties

@@ -1,3 +1,6 @@
 popupTitle=Crear nuevo
 itemNameSubheading=Nombre\:
 fileNameIsMandatory=Falta el nombre para el nuevo recurso. Por favor ingrese uno.
+resourceName=Nombre de recurso
+location=Localización
+resourceNamePlaceholder=nombre de recurso...