Generate timezone-aware dates and datetimes if the timezone support is enabled. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… end of a Daylight Saving Time period.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One can get a huge amount of warnings looking like this:
/django/db/models/fields/init.py:808: RuntimeWarning: DateTimeField received a naive datetime (1999-01-25 20:06:41) while time zone support is active.
when the Django 1.4 timezone support is enabled.
This patch fixes the issue.
It also fixes another issue: sometimes a generated datetime value becomes invalid when timezone rules are applied to it. Each year we skip a hour when applying daytime saving time rules. Sometimes a generated 'naive' value hits one of these skipped hours when become a timezone-aware. This may result in random errors and test failures.