Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Segmentation fault in output.c:49:16 #58

Closed
seviezhou opened this issue Aug 30, 2020 · 0 comments · Fixed by #66
Closed

A Segmentation fault in output.c:49:16 #58

seviezhou opened this issue Aug 30, 2020 · 0 comments · Fixed by #66

Comments

@seviezhou
Copy link

System info

Ubuntu x86_64, clang 6.0, faad (latest master 1073ae)

Configure

CFLAGS="-g -fsanitize=address" LDFLAGS="-fsanitize=address" ./configure --enable-shared=no

Command line

./frontend/faad -w -b 5 @@

AddressSanitizer output

NULL	190.264 secs, 6 ch, 44100 Hz

AddressSanitizer:DEADLYSIGNAL
=================================================================
==3662==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x000000546b64 bp 0x629000000200 sp 0x7ffed5a32ff0 T0)
==3662==The signal is caused by a READ memory access.
==3662==Hint: address points to the zero page.
    #0 0x546b63 in get_sample /home/seviezhou/faad2/libfaad/output.c:49:16
    #1 0x546b63 in to_PCM_double /home/seviezhou/faad2/libfaad/output.c:390
    #2 0x546b63 in output_to_PCM /home/seviezhou/faad2/libfaad/output.c:427
    #3 0x53b8df in aac_frame_decode /home/seviezhou/faad2/libfaad/decoder.c:1176:21
    #4 0x52f738 in decodeMP4file /home/seviezhou/faad2/frontend/main.c:916:25
    #5 0x52f738 in faad_main /home/seviezhou/faad2/frontend/main.c:1323
    #6 0x7fb2de93483f in __libc_start_main /build/glibc-e6zv40/glibc-2.23/csu/../csu/libc-start.c:291
    #7 0x41a698 in _start (/home/seviezhou/faad2/frontend/faad+0x41a698)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV /home/seviezhou/faad2/libfaad/output.c:49:16 in get_sample
==3662==ABORTING

POC

SEGV-get_sample-output-49.zip

awesie added a commit to awesie/faad2 that referenced this issue Oct 9, 2020
hInfo->error is reset within the decode_* functions. This caused the decoder
to ignore errors for some channels in the error resilience (ER) code path.

Fixes knik0#58.
awesie added a commit to awesie/faad2 that referenced this issue Oct 9, 2020
hInfo->error is reset within the decode_* functions. This caused the decoder
to ignore errors for some channels in the error resilience (ER) code path.

Fixes knik0#58.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant