Skip to content

Commit

Permalink
argument shifting is not done correctly when the options argument is …
Browse files Browse the repository at this point in the history
…not supplied. the result is that the callback is not called. this fixes Ticket #5731
  • Loading branch information
kobrigo committed Jun 16, 2010
1 parent 9241757 commit 01dcb63
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions ui/jquery.effects.core.js
Expand Up @@ -418,15 +418,15 @@ function _normalizeArguments(effect, options, speed, callback) {
speed = null;
options = {};
}
if ($.isFunction(speed)) {
callback = speed;
speed = null;
}
if (typeof options == 'number' || $.fx.speeds[options]) {
if (typeof options == 'number' || $.fx.speeds[options]) {
callback = speed;
speed = options;
options = {};
}
if ($.isFunction(speed)) {
callback = speed;
speed = null;
}

options = options || {};

Expand Down

2 comments on commit 01dcb63

@scottgonzalez
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I pulled this over, but had to update your commit message. Check out our bug fixing guide at http://wiki.jqueryui.com/Bug-Fixing-Guide for how to properly format your commit message (at the bottom of the page).

@scottgonzalez
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm updating the list of authors for jQuery UI and I can't find your name anywhere. Could you send me your first and last name? Thanks.

Please sign in to comment.