New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement PVR API 5.1.0 #206
Conversation
@MilhouseVH could you do a runtime test? |
@ksooo demuxer changes look ok but runtime test is more important in this case. |
Hmm. Sounds like a general problem, not only pvr.hts related. Whatever you guys say makes sense. I only would like to avoid another API bump right now. Regardless of the version number it's always PITA and I really would like somebody else to do the next monkey work, then. |
Wouldn't proper |
Yes a |
Fair enough. For now I would like to go with the memset approach. Okay? |
To be honest I don't personally use any PVR functionality so runtime testing is difficult. I can build test it, that's about it - I leave runtime testing to the test users. :) |
... now with memset. |
Runtime tested. Works to some extend. One can watch tv, but on some channels audio stops after 3-5 seconds. Don't think this is an add-on problem. @Jalle19 I suggest to merge this PR as it is now, so we have at least a compatible add-on again. Okay? |
Lets fix this with the next API bump, which I'm pretty sure will come up before Krypton release anyway. @Jalle19 okay to merge? |
Yeah go ahead, no point in having a broken addon. |
Refer to xbmc/xbmc#9290 and xbmc/xbmc#9295 for details.
@FernetMenta demuxer changes good to go?
@Jalle19 good to go?