Fix sqlalchemy table.exists deprecated usage

kolotaev · Apr 5, 2023 · 51cdc57 · 51cdc57
1 parent f1db00b
commit 51cdc57
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/setup.py b/setup.py
@@ -29,8 +29,6 @@
             'jsonpickle>=2.0',
         ],
         extras_require={
-            # Dev dependencies are not using pinned compatibility versions
-            # in order to support a wide array of Python versions
             'dev': [
                 'pytest~=7.0',
                 'pytest-cov~=4.0',

diff --git a/tests/storage/sql/test_migrations.py b/tests/storage/sql/test_migrations.py
@@ -1,5 +1,5 @@
 import pytest
-from sqlalchemy import create_engine
+from sqlalchemy import create_engine, inspect
 from sqlalchemy.orm import sessionmaker, scoped_session
 
 from vakt.storage.sql import SQLStorage
@@ -72,14 +72,16 @@ def test_has_access_to_storage(self, migration):
 
     def test_up(self, migration, engine):
         migration.up()
-        assert Base.metadata.tables[PolicyModel.__tablename__].exists(engine)
-        assert Base.metadata.tables[PolicySubjectModel.__tablename__].exists(engine)
-        assert Base.metadata.tables[PolicyResourceModel.__tablename__].exists(engine)
-        assert Base.metadata.tables[PolicyActionModel.__tablename__].exists(engine)
+        inspector = inspect(engine)
+        assert inspector.has_table(PolicyModel.__tablename__)
+        assert inspector.has_table(PolicySubjectModel.__tablename__)
+        assert inspector.has_table(PolicyResourceModel.__tablename__)
+        assert inspector.has_table(PolicyActionModel.__tablename__)
 
     def test_down(self, migration, engine):
         migration.down()
-        assert not Base.metadata.tables[PolicyModel.__tablename__].exists(engine)
-        assert not Base.metadata.tables[PolicySubjectModel.__tablename__].exists(engine)
-        assert not Base.metadata.tables[PolicyResourceModel.__tablename__].exists(engine)
-        assert not Base.metadata.tables[PolicyActionModel.__tablename__].exists(engine)
+        inspector = inspect(engine)
+        assert not inspector.has_table(PolicyModel.__tablename__)
+        assert not inspector.has_table(PolicySubjectModel.__tablename__)
+        assert not inspector.has_table(PolicyResourceModel.__tablename__)
+        assert not inspector.has_table(PolicyActionModel.__tablename__)