Update to Elastic 8, use external cluster #767
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extras if --extra-tags is not specified
INF-252, INF-253 | feat: adapt photon for feature parity with toby's version
…eates invalid offsets when used with preserve_original (source: https://www.elastic.co/guide/en/elasticsearch/reference/current/analysis-word-delimiter-graph-tokenfilter.html)
…break all the tests in the process...)
…ake it closer to the original implementation (this provided a 10x speedup on initial testing), add -fresh-cluster and -continue-import args to allow more control over the pre-import steps
…f not provided, do not refresh index settings by default as it has side effects, dockerfile to serve api
|
Any update for PR? Has this update changed the logic of search of Photon that affects search results or change logic to connect to external ES? Tks for your PR. We also want to deploy external ES. |
|
This PR has mixed in too many other new features and is missing a solution for the tests. Those are blockers for merging. I'm leaving the PR open for now, given that ES 8 is requested a lot and people might want to play with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some major changes to support modern Elasticsearch, decoupling the cluster from import and search features. My company tasked me with adapting Photon such that we can host the cluster externally with ElasticCloud. We now have this working in our dev environment, and plan to ship to production in the new year.
No expectations from me (it's a huge set of changes and will break any existing deployment), but I wanted to contribute nonetheless in-case you wanted to use or take ownership of any of the changes.
Being able to deploy externally on an updated ES version has been huge for us in terms of performance and cost. Hopefully it will be useful to others too!
NB: tests probably broken