Skip to content

Commit

Permalink
kodev check: enforce default submodule.recurse=false for shellcheck &…
Browse files Browse the repository at this point in the history
… shfmt on submodules (#10362)

Otherwise results might be unexpected for people who set submodule.recurse to true

Regression of sorts since #10344
  • Loading branch information
yparitcher committed Apr 27, 2023
1 parent 6c2f230 commit b5fda00
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kodev
Expand Up @@ -994,7 +994,7 @@ function kodev-check() {
check_submodules

# shellcheck disable=2016
mapfile -t shellscript_locations < <({ git grep -lE '^#!(/usr)?/bin/(env )?(bash|sh)' | sed "/^plugins\/terminal.koplugin\/shfm$/d" && git submodule --quiet foreach '[ "$path" = "base" -o "$path" = "platform/android/luajit-launcher" ] || git grep -lE "^#!(/usr)?/bin/(env )?(bash|sh)" | sed "s|^|$path/|"' && git ls-files ./*.sh; } | sort | uniq)
mapfile -t shellscript_locations < <({ git -c submodule.recurse=0 grep -lE '^#!(/usr)?/bin/(env )?(bash|sh)' | sed "/^plugins\/terminal.koplugin\/shfm$/d" && git submodule --quiet foreach '[ "$path" = "base" -o "$path" = "platform/android/luajit-launcher" ] || git grep -lE "^#!(/usr)?/bin/(env )?(bash|sh)" | sed "s|^|$path/|"' && git ls-files ./*.sh; } | sort | uniq)

SHFMT_OPTIONS="-i 4 -ci"

Expand Down

0 comments on commit b5fda00

Please sign in to comment.