Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typos and minor fixes #3429

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Typos and minor fixes #3429

wants to merge 2 commits into from

Conversation

alpe
Copy link

@alpe alpe commented Feb 13, 2024 •
edited

What this PR does / why we need it:
Minor chore. I was reading the file and added some fixes for typos or godoc standard

alpe
alpe commented Feb 13, 2024
View reviewed changes
pkg/controller/v1beta1/inferenceservice/controller.go Outdated
r.Recorder.Eventf(isvc, v1.EventTypeWarning, "InternalError", err.Error())
r.updateStatus(isvc, deploymentMode)
r.Recorder.Event(isvc, v1.EventTypeWarning, "InternalError", err.Error())
_ = r.updateStatus(isvc, deploymentMode)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stumbled upon this line and was wondering why this update call exists. The error was not handled, so it would be good to mark it explicit to be ignored. I am not sure if this is the right behaviour though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is handled in PR #3378

@alpe
Typos and minor fixes
0810262 
Signed-off-by: Alex Peters <alpe@users.noreply.github.com>
@sivanantha321
Copy link
Member

/lgtm

@oss-prow-bot oss-prow-bot bot added the lgtm label Feb 17, 2024
terrytangyuan
terrytangyuan approved these changes Feb 17, 2024
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@oss-prow-bot OSS-prow-bot
Copy link

oss-prow-bot bot commented Feb 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alpe, terrytangyuan
Once this PR has been reviewed and has the lgtm label, please assign rachitchauhan43 for approval by writing /assign @rachitchauhan43 in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuzisun
Merge branch 'master' into inference_minor_cleanup
bcc52f4 
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@oss-prow-bot oss-prow-bot bot removed the lgtm label May 4, 2024
@oss-prow-bot OSS-prow-bot
Copy link

oss-prow-bot bot commented May 4, 2024

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivanantha321 sivanantha321 sivanantha321 left review comments

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@adriangonz adriangonz Awaiting requested review from adriangonz

@ckadner ckadner Awaiting requested review from ckadner

Assignees

@terrytangyuan terrytangyuan

@sivanantha321 sivanantha321

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alpe @sivanantha321 @terrytangyuan @yuzisun