Fix docker build failures for arm64 and restrict ray serve to ~2.10.0 #3630
Conversation
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sivanantha321 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sivanantha321
force-pushed
the
fix-arm64-build-fail
branch
from
22306cd
to
aea6484
Compare
| @@ -9,7 +9,8 @@ ARG POETRY_HOME=/opt/poetry | |||
| ARG POETRY_VERSION=1.7.1 | |||
|
|
|||
| # Required for building packages for arm64 arch | |||
| RUN apt-get update && apt-get install -y --no-install-recommends python3-dev build-essential | |||
| RUN apt-get update && apt-get install -y --no-install-recommends python3-dev build-essential pkg-config libhdf5-dev && \ | |||
There was a problem hiding this comment.
for arm we could pin the h5py version to 2.10 (IIRC) instead doing it here.
wdyt?
There was a problem hiding this comment.
A similar thing opendatahub-io/modelmesh-runtime-adapter#55
There was a problem hiding this comment.
We already doing some compiling for ARM64 and after reading the comment here I am not sure when the ARM builds will be available.
There was a problem hiding this comment.
Oh, for now we could stick with 3.10 and wait for that. =/
There was a problem hiding this comment.
we still can use h5py with newer python versions, right?
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
sivanantha321
force-pushed
the
fix-arm64-build-fail
branch
from
aea6484
to
edfc305
Compare
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note: