Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kubernetes Doc Links #3670

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jyono
Copy link

@jyono jyono commented May 7, 2024

What this PR does / why we need it:
Existing docs return a 404. They are simply invalid..

Type of changes
Please delete options that are not relevant.

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Release note:


Re-running failed tests

  • /rerun-all - rerun all failed workflows.
  • /rerun-workflow <workflow name> - rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.

Copy link
Contributor

@spolti spolti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you sign the DCO for your commits?

@oss-prow-bot oss-prow-bot bot removed the lgtm label May 7, 2024
cmaddalozzo and others added 3 commits May 7, 2024 11:19
Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net>
Signed-off-by: jordanyono <jordanyono@gmail.com>
Signed-off-by: jordanyono <jordanyono@gmail.com>
Signed-off-by: jordanyono <jordanyono@gmail.com>
@jyono jyono force-pushed the jyono-fix-annotations-doc branch from 5bf895a to 8a2367b Compare May 7, 2024 15:19
@jyono
Copy link
Author

jyono commented May 7, 2024

Could you sign the DCO for your commits?

@terrytangyuan okay, finally got it right 😅 :

@jyono jyono requested review from terrytangyuan and spolti May 7, 2024 15:19
@spolti
Copy link
Contributor

spolti commented May 7, 2024

guess you need to rebase

@jyono
Copy link
Author

jyono commented May 7, 2024

guess you need to rebase

@spolti
synced the fork. good now 😁.

Copy link
Contributor

@spolti spolti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm

@oss-prow-bot oss-prow-bot bot added the lgtm label May 8, 2024
@jyono
Copy link
Author

jyono commented May 8, 2024

/assign @njhill

@yuzisun
Copy link
Member

yuzisun commented May 11, 2024

@jyono seems like the codegen is still out of sync

@oss-prow-bot oss-prow-bot bot removed the lgtm label May 20, 2024
Copy link

oss-prow-bot bot commented May 20, 2024

New changes are detected. LGTM label has been removed.

Copy link

oss-prow-bot bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jyono, spolti
Once this PR has been reviewed and has the lgtm label, please ask for approval from njhill by writing /assign @njhill in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jyono
Copy link
Author

jyono commented May 20, 2024

@jyono seems like the codegen is still out of sync

Do you have any advice on fixing it? the error log is gone. I've been trying

make generate and KSERVE_PATH="github.com/kserve/kserve" make generate locally, but am getting errors

ERROR:
	 API rule check failed. Reported violations in file hack/current_violation_exceptions.list differ from known violations in file hack/violation_exceptions.list.

make: *** [Makefile:190: generate] Error 1

I was on vacation for a week so it seems the GHA logs are gone.

Maybe another approval to run codegen again?

/assign @njhill

@jyono jyono requested a review from spolti May 20, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants