Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generate VIPCIDR if not value is set #853

Merged
merged 1 commit into from
May 17, 2024
Merged

feat: generate VIPCIDR if not value is set #853

merged 1 commit into from
May 17, 2024

Conversation

M0NsTeRRR
Copy link
Contributor

Fix #852

@M0NsTeRRR
feat: generate VIPCIDR if not value is set
28918e8 
Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>
@M0NsTeRRR M0NsTeRRR requested a review from thebsdbox as a code owner May 16, 2024 20:44
thebsdbox
thebsdbox approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@thebsdbox thebsdbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This looks great.

@thebsdbox thebsdbox merged commit 392583d into kube-vip:main May 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebsdbox thebsdbox thebsdbox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default value of vip_cidr
2 participants
@M0NsTeRRR @thebsdbox