Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Routes get not deleted when kube-vip is running without LeaderElection/ServiceElection in Table Mode #854

Merged
merged 1 commit into from
May 17, 2024

Conversation

Cellebyte
Copy link
Collaborator

  • When running kube-vip without vip_leaderelection or svc_election it only deletes IPs from interfaces but never deleted the Route from the RoutingTable in Table Mode
  • This change would introduce a bit of cluttering in the logs, when Routes are not installed on a particular node but kube-vip is trying to delete the route for a service when in TableMode
  • Functionally it should not break any existing setup using TableMode it just cleans Routes after the Service gets deleted

@Cellebyte Cellebyte requested a review from thebsdbox as a code owner May 17, 2024 10:26
Signed-off-by: Marcel Fest <marcel.fest@telekom.de>
@Cellebyte Cellebyte changed the title [Hotfix] Routes get not deleted when kube-vip is running without LeaderElection/ServiceElection in Table Mode Draft: [Hotfix] Routes get not deleted when kube-vip is running without LeaderElection/ServiceElection in Table Mode May 17, 2024
@Cellebyte Cellebyte changed the title Draft: [Hotfix] Routes get not deleted when kube-vip is running without LeaderElection/ServiceElection in Table Mode [Hotfix] Routes get not deleted when kube-vip is running without LeaderElection/ServiceElection in Table Mode May 17, 2024
@thebsdbox
Copy link
Collaborator

/lgtm

@Cellebyte
Copy link
Collaborator Author

I will merge it after it was tested ^^

@Cellebyte Cellebyte merged commit c683bb8 into main May 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants