Updates Thanos Aggregator migration diagrams #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also want to note that I may expand on this PR to update more diagrams, or file them separately. Either way the plan is to update some of the older or less legible images in our docs |
thomasvn
approved these changes
May 20, 2024
There was a problem hiding this comment.
Thanks for doing this @bstuder99! Is there any place you're editing/saving your diagrams at? Would love for it to be a shared location so we can continuously iterate & collaborate on them.
|
We should have a shared Google Drive folder through draw.io where these are saved, let me know if you can't find them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Proposed Changes
Updated architecture diagram using draw.io for a cleaner and more legible look. Just a basic draft, if we want to tweak any of the design choices (colors etc), let me know