Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for https backend traffic within cluster without certificates #392

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow for https backend traffic within cluster without certificates #392

wants to merge 1 commit into from

Conversation

andersla
Copy link
Member

@andersla andersla commented May 28, 2018 •
edited

Change content and motivation

Allow for https backend traffic within cluster without certificates. Kubernetes Dashboard helm chart is now only serving internal traffic as https and internal handshake fails if traefik tries to forward traffic without valid certs.

@andersla andersla changed the title Allow for https backend traefic within cluster without certificates Allow for https backend traffic within cluster without certificates May 28, 2018
@mcapuccini mcapuccini self-requested a review May 28, 2018 08:50
mcapuccini
mcapuccini requested changes May 28, 2018
View reviewed changes
Copy link
Member

@mcapuccini mcapuccini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! That should be false by default IMO, because as you write it can expose the cluster to possible attack. Possible solutions:

  • Have it commented by default
  • Having some sort of conditionals

@mcapuccini mcapuccini added this to the 0.4.0 milestone Jun 13, 2018
@mcapuccini mcapuccini removed this from the 0.4.0 milestone Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcapuccini mcapuccini mcapuccini requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andersla @mcapuccini