-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump CSI spec to next version #515
base: master
Are you sure you want to change the base?
Conversation
Welcome @huww98! |
Hi @huww98. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: huww98 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think we do not update to unreleased CSI spec version. |
The next CSI spec version will bring a breaking change, so I just raised this PR earlier to fix it, so that we can do the tests and review earlier. |
/ok-to-test I'm enabling CI in this PR to see any breakages then. |
it contains mutex in new version
and fix the build failure
it is outdated and replaced by google.golang.org/protobuf
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
bump CSI spec to next version and fix the build failure
remove direct deps on
github.com/golang/protobuf
. Since it is outdated and replaced bygoogle.golang.org/protobuf
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This uses an unreleased version of CSI spec. If we are not in hurry merging this, I'll update this PR when a new release is available.
Does this PR introduce a user-facing change?: