This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Disable tip on travis #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bprashanth ? That file doesn't DO anything... At least I sure don't think so. It's just the version of go the person had when they updated the godeps.... |
|
isn't it the godep.json travis consults for actions like godep restore etc (specifically godep go install ./...)? It's just a shot in the dark about why we're seeing the weird travis failures that I haven't debugged |
|
I think it's the golang -tip is just busted somehow.... |
bprashanth
force-pushed
the
goversion
branch
from
411f310
to
470983e
Compare
|
@eparis disable tip? hah |
|
At least you got a green CI run... |
|
Alright assigning to you, we don't care about tip right? looks like in main repo we only have 1.4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was changed in #226 and I suspect it's what's breaking Travis. This pr is a test to see if it fixes things.