-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cluster-autoscaler/exoscale): add support for --nodes #6771
feat(cluster-autoscaler/exoscale): add support for --nodes #6771
Conversation
Hi @thomasstxyz. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this change! Nice work, it's clear :)
/approve |
/lgtm |
@pierre-emmanuelJ: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
f48f832
to
721c4e4
Compare
Please review and approve @gjtempleton @feiskyer @BigDarkClown thanks |
/assign @gjtempleton |
/approve |
/ok-to-test |
charts/cluster-autoscaler/Chart.yaml
Outdated
@@ -11,4 +11,4 @@ name: cluster-autoscaler | |||
sources: | |||
- https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler | |||
type: application | |||
version: 9.37.0 | |||
version: 9.37.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomasstxyz
This is a new feature, please make this a minor version bump.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shubham82 Done.
721c4e4
to
3b5ec0d
Compare
Thanks @thomasstxyz |
@Shubham82 is there anything to do from my side? |
For me, it looks good. |
CC @gjtempleton could you please approve this PR so it will be merged? Thanks! |
@thomasstxyz, please resolve the merge conflict. |
3b5ec0d
to
1d605b1
Compare
/lgtm |
Signed-off-by: Thomas Stadler <thomas.stadler@whizus.com>
1d605b1
to
5abbb4a
Compare
/lgtm |
Hi @gjtempleton @jackfrancis Thanks! |
Thanks for this, good to see. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gjtempleton, PhilippeChepy, pierre-emmanuelJ, sauterp, thomasstxyz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is it nodepool-name? Or nodepool-id? Or instancepool-id? |
nodepool-name |
What type of PR is this?
/kind feature
What this PR does / why we need it:
cluster-autoscaler/exoscale: This PR adds support for configuration of minimum and maximum size of specified node groups via the
--nodes=<min>:<max>:<nodepool-name>
flag.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: