Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for cri-tools #2191

Merged
merged 1 commit into from Jun 11, 2018
Merged

Update docs for cri-tools #2191

merged 1 commit into from Jun 11, 2018

Conversation

feiskyer
Copy link
Member

@feiskyer feiskyer commented May 25, 2018 •
edited

Documentation for kubernetes/enhancements#292.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 25, 2018
@feiskyer
Copy link
Member Author

/cc @yujuhong @Random-Liu

@k8s-ci-robot k8s-ci-robot requested review from calebamiles, grodrigues3, Random-Liu and yujuhong and removed request for calebamiles and grodrigues3 May 25, 2018 07:30
@idvoretskyi
Copy link
Member

cc @kubernetes/sig-node-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label May 30, 2018
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 4, 2018
@feiskyer
Copy link
Member Author

feiskyer commented Jun 4, 2018

/assign @Random-Liu @yujuhong

yujuhong
yujuhong reviewed Jun 4, 2018
View reviewed changes
contributors/devel/cri-validation.md Outdated

- By setting flags `--runtime-endpoint` and `--image-endpoint`
- By setting environment variables `CRI_RUNTIME_ENDPOINT` and `CRI_IMAGE_ENDPOINT`
critest connects to `unit:///var/run/dockershim.sock` by default. For other runtimes, the endpoint can be set by flags `-runtime-endpoint` and `-image-endpoint`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/unit/unix

Is it -runtime-endpoint or --runtime-endpoint?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, those options are Go flags, so -runtime-endpoint is right. Also additional flags are in same format.

contributors/devel/cri-validation.md
critest connects to `/var/run/dockershim.sock` by default. For other runtimes, the endpoint can be set in two ways:

- By setting flags `--runtime-endpoint` and `--image-endpoint`
- By setting environment variables `CRI_RUNTIME_ENDPOINT` and `CRI_IMAGE_ENDPOINT`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were the environment variables removed, and why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, those environment variables are introduced with lib github.com/urfave/cli. But with this lib, critest requires Go installed whenever running validation tests. So we moved to go test -c for building critest binary and it doesn't require Go for running critest.

@feiskyer
Copy link
Member Author

feiskyer commented Jun 5, 2018

@yujuhong Addressed comments. PTAL

@yujuhong
Copy link
Contributor

yujuhong commented Jun 5, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2018
@feiskyer
Copy link
Member Author

@cblecker Could you help to approve the PR?

@cblecker
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2018
@k8s-ci-robot k8s-ci-robot merged commit bb1f3b1 into kubernetes:master Jun 11, 2018
@feiskyer feiskyer deleted the cri branch June 12, 2018 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yujuhong yujuhong yujuhong left review comments

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

Assignees

@Random-Liu Random-Liu

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@feiskyer @idvoretskyi @yujuhong @cblecker @k8s-ci-robot @Random-Liu