-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in Korean version of contributor cheat sheet #7064
Fix typo in Korean version of contributor cheat sheet #7064
Conversation
Welcome @KENNYSOFT! |
Hi @KENNYSOFT. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test Is it possible to get a Docs Korean reviewer to take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KENNYSOFT 기여에 감사드립니다.
일부 문장을 조금 더 자연스럽게 해 보았습니다.
확인해 보시고, 선택적으로 반영하시면 되겠습니다. 😊
Thanks @cblecker :) Hi @KENNYSOFT Could you help ? :) |
/approve Thank you @seokho-son @jihoon-seo! When things are addressed to your satisfaction, please feel free to remove the hold. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, KENNYSOFT The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>
/label tide/merge-method-squash |
Uhm looks like 'tide' is triggered before my last modification... 😭 |
@KENNYSOFT 가능하신 경우, 여러 커밋들을 1개 커밋으로 수동으로 squash 해 주시면 더 좋습니다. 😊 |
I think this PR is ready to be merged ! Thanks all. /hold cancel |
/lgtm |
Fix the typo of 조사(conjunction) in the Korean version of the contributor cheat sheet.