Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Korean version of contributor cheat sheet #7064

Merged

Conversation

KENNYSOFT
Copy link
Contributor

Fix the typo of 조사(conjunction) in the Korean version of the contributor cheat sheet.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 24, 2023
@k8s-ci-robot k8s-ci-robot added the area/contributor-guide Issues or PRs related to the contributor guide label Jan 24, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @KENNYSOFT!

It looks like this is your first PR to kubernetes/community 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/community has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 24, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @KENNYSOFT. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cblecker
Copy link
Member

cblecker commented Feb 2, 2023

/ok-to-test
/cc @kubernetes/sig-docs-ko-reviews @kubernetes/sig-docs-ko-owners

Is it possible to get a Docs Korean reviewer to take a look at this?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 2, 2023
Copy link
Member

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KENNYSOFT 기여에 감사드립니다.
일부 문장을 조금 더 자연스럽게 해 보았습니다.
확인해 보시고, 선택적으로 반영하시면 되겠습니다. 😊

contributors/guide/contributor-cheatsheet/README-ko.md Outdated Show resolved Hide resolved
contributors/guide/contributor-cheatsheet/README-ko.md Outdated Show resolved Hide resolved
@seokho-son
Copy link
Member

Thanks @cblecker :)
Sure, sig-docs-ko-reviews / approvers can review this PR. :)

Hi @KENNYSOFT
I think your suggestion is acceptable as is. Thank you for your contribution!
Even though this PR is accepted as is, If you can update the PR according to @jihoon-seo 's comment I think it will enhance the document better.

Could you help ? :)

@cblecker
Copy link
Member

cblecker commented Feb 3, 2023

/approve
/hold

Thank you @seokho-son @jihoon-seo! When things are addressed to your satisfaction, please feel free to remove the hold.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, KENNYSOFT

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2023
Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>
@jihoon-seo
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 3, 2023
@KENNYSOFT
Copy link
Contributor Author

Uhm looks like 'tide' is triggered before my last modification... 😭

@jihoon-seo
Copy link
Member

@KENNYSOFT
'tide/merge-method-squash' label은,
이 PR이 trivial한 back-and-forth 커밋 여러개로 이루어져 있는 상태에서 merge 되는 것은 바람직하지 않다고 생각하여
추후 bot이 이 PR을 merge 시 squash merge 하도록 하는 label을 추가한 것입니다. 😊

가능하신 경우, 여러 커밋들을 1개 커밋으로 수동으로 squash 해 주시면 더 좋습니다. 😊

@seokho-son
Copy link
Member

I think this PR is ready to be merged ! Thanks all.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2023
@seokho-son
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 70990f1 into kubernetes:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/contributor-guide Issues or PRs related to the contributor guide cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants