Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-753: introduce a second KEP and gate for restarts during pod termination #4324

Merged
merged 1 commit into from Jan 30, 2024
Merged

KEP-753: introduce a second KEP and gate for restarts during pod termination #4324

merged 1 commit into from Jan 30, 2024

Conversation

matthyx
Copy link
Contributor

@matthyx matthyx commented Oct 31, 2023 •
edited by pacoxu

  • One-line PR description: introduce a second feature flag for restarting sidecars during pod termination
  • Other comments:

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 31, 2023
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 31, 2023
@matthyx matthyx marked this pull request as ready for review November 2, 2023 06:53
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2023
@bart0sh bart0sh added this to Triage in SIG Node PR Triage Nov 7, 2023
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Nov 8, 2023
@gjkim42
Copy link
Member

gjkim42 commented Jan 6, 2024

/cc

@matthyx
Copy link
Contributor Author

matthyx commented Jan 16, 2024

@mrunalp can you have a look? we need to merge this before starting working on it for 1.30

SergeyKanzhelev
SergeyKanzhelev approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2024
@bart0sh bart0sh moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Jan 25, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 28, 2024
@matthyx matthyx changed the title KEP-753: introduce a second gate for restarts during pod termination KEP-753: introduce a second KEP and gate for restarts during pod termination Jan 28, 2024
This was referenced Jan 29, 2024
Open
Open
@matthyx @tzneal
KEP-753: introduce a second KEP and gate for restarts during pod term…
f5b82bb 
…ination

Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>

Co-authored-by: Todd Neal <todd@tneal.org>
@matthyx
Copy link
Contributor Author

matthyx commented Jan 30, 2024

/assign @johnbelamaric

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matthyx, mrunalp, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
@SergeyKanzhelev
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7f6c975 into kubernetes:master Jan 30, 2024
4 checks passed
SIG Node PR Triage automation moved this from Needs Approver to Done Jan 30, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 30, 2024
@matthyx matthyx deleted the restart branch February 1, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzneal tzneal tzneal left review comments

@mrunalp mrunalp mrunalp approved these changes

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@gjkim42 gjkim42 Awaiting requested review from gjkim42

Assignees

@johnbelamaric johnbelamaric

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
SIG Node PR Triage
Done
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@matthyx @k8s-ci-robot @gjkim42 @SergeyKanzhelev @mrunalp @tzneal @johnbelamaric