KEP-4590: CEL Variables in Schemas #4583
Conversation
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
cncf-cla: yes
alexzielenski
changed the title
|
Please open an issue for this KEP. It's a requirement for opening a pull request here. Fill out the sections that you have info for, at this draft stage we're mostly just ensuring that you're opening the PR with the go-ahead from the sponsoring SIG and have been in some communication with them. If you have any questions, please let me know. Thanks! |
alexzielenski
force-pushed
the
crd-cel-variables
branch
3 times, most recently
from
f118cd3
to
31fbdde
Compare
alexzielenski
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
alexzielenski
force-pushed
the
crd-cel-variables
branch
from
31fbdde
to
d97ae9d
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alexzielenski The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@alexzielenski: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| } | ||
| ``` | ||
|
|
||
| The schema validator will allow shadowing of variables defined in parent |
There was a problem hiding this comment.
+1, this becomes essential for embedded resource composition. If someone puts the schema of some resource into another, having to deconflict variable names would unfortunate.
|
|
||
| * Ability to Embed Parameterized Schemas by overriding variables - This is seen as a future work | ||
|
|
||
| ## Proposal |
There was a problem hiding this comment.
Variables and depend on other variable that are defined earlier in the list? VAP supported depending on variables earlier in the list so we can just follow precedence on that.
| ``` | ||
|
|
||
| The schema validator will allow shadowing of variables defined in parent | ||
| schemas. |
There was a problem hiding this comment.
User defined variables are accessed through the 'variables.(variable name)' form like done via VAP? (I'm assuming yes)
|
|
||
| The schema validator will allow shadowing of variables defined in parent | ||
| schemas. | ||
|
|
There was a problem hiding this comment.
Explain variable scope and shadowing in more detail? My assumption is that a variable in the data tree is in scope for all children (unless shadowed)
| will be made available under Alpha->Beta->GA release cycle to mitigate the | ||
| risk of bugs. | ||
|
|
||
| Note that this requires a way of detecting whiwch CEL expressions refer to variables, |
There was a problem hiding this comment.
| Note that this requires a way of detecting whiwch CEL expressions refer to variables, | |
| Note that this requires a way of detecting which CEL expressions refer to variables, |
/cc @jpbetz @cici37 @jiahuif @sttts