Horizontal Pod Autoscaler to reach proper size faster

[jbartosik]

One-line feature description (can be used as a release note):

Improvements allowing Horizontal Pod Autoscaler to reach proper size faster

• Primary contact (assignee): @jbartosik
• Responsible SIGs: @kubernetes/sig-autoscaling
• Design proposal link (community repo):
• Link to e2e and/or unit tests:
  • Unit tests: https://github.com/kubernetes/kubernetes/tree/master/pkg/controller/podautoscaler, https://github.com/kubernetes/kubernetes/blob/master/test/e2e/autoscaling/custom_metrics_stackdriver_autoscaling.go
• Reviewer(s): @DirectXMan12 @mwielgus @MaciekPytel
• Approver (likely from SIG/area to which feature belongs): @DirectXMan12 @mwielgus
• Feature target (which target equals to which milestone):
  • Alpha release target (x.y) 1.12
  • Beta release target (x.y) 1.12
  • Stable release target (x.y)

[justaugustus]

@mwielgus --

It looks like this feature is currently in the Kubernetes 1.12 Milestone.

If that is still accurate, please ensure that this issue is up-to-date with ALL of the following information:

• One-line feature description (can be used as a release note):
• Primary contact (assignee):
• Responsible SIGs:
• Design proposal link (community repo):
• Link to e2e and/or unit tests:
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
• Approver (likely from SIG/area to which feature belongs):
• Feature target (which target equals to which milestone):
  • Alpha release target (x.y)
  • Beta release target (x.y)
  • Stable release target (x.y)

Set the following:

• Description
• Assignee(s)
• Labels:
  • stage/{alpha,beta,stable}
  • sig/*
  • kind/feature

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.

---

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

• Docs deadline (open placeholder PRs): 8/21
• Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

/kind feature
/stage alpha

[justaugustus]

/stage alpha

[jbartosik]

@justaugustus stage should be beta (I'm making changes to HPA algorithm, which is in beta), the issue already has correct sig/ and kind/ labels.

Could you tell me how should I improve the description?

[justaugustus]

Thanks for the update! This has been added to the 1.12 Tracking sheet.

/remove-stage alpha
/stage beta

[zparnold]

Hey there! @jbartosik I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

[jbartosik]

@zparnold Sure. I can open a PR this week. I'm on vacation for two week after that so I'd like to know:

• By when would you like me to open the PR (is this week ok)?
• By when would you like to have the PR merged (if it's sooner than in 3 weeks I will have to ask a coworker to take care of the PR)?

[zparnold]

I believe the docs deadline is 2 weeks out (the signed, sealed, delivered date) so it would be awesome to have it by then. Take care, Zach

…

On Mon, Aug 20, 2018 at 1:32 PM Joachim ***@***.***> wrote: @zparnold <https://github.com/zparnold> Sure. I can open a PR this week. I'm on vacation for two week after that so I'd like to know: - By when would you like me to open the PR (is this week ok)? - By when would you like to have the PR merged (if it's sooner than in 3 weeks I will have to ask a coworker to take care of the PR)? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#591 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE81SHyfy-BCC8kAXWZko6rm3-CPwV1aks5uSxz4gaJpZM4VWpEE> .

[jbartosik]

@zparnold since you'd like the doc PR submitted when I'm away (09-03) I'll ask my coworker to take care of it if needed.

[zparnold]

Ok, thank you so much for your prompt reply!

[DirectXMan12]

I already have a PR that partially includes these changes at kubernetes/website#9780. Please make sure to take that into account when writing docs.

[zparnold]

Thanks!

…

On Tue, Aug 21, 2018 at 12:56 PM Solly Ross ***@***.***> wrote: I already have a PR that partially includes these changes at kubernetes/website#9780 <kubernetes/website#9780>. Please make sure to take that into account when writing docs. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#591 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE81SPfoctsEJYMrlZVZRFiXJpqwqtblks5uTEnLgaJpZM4VWpEE> .

[justaugustus]

@DirectXMan12 --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

[DirectXMan12]

It landed. My docs were partial docs, but I'd expect @krzysztof-jastrzebski (one of the authors) to write the remainder of the docs. Worst comes to worst, I can fill in the rest, though.

[DirectXMan12]

Also, my PR seems to have languished a bit without any review. I'll need to rebase it, but it would be useful to get feedback too (kubernetes/website#9780)

[DirectXMan12]

I'll be filling in the rest due to deadlines and availability. I'll update the aforementioned PR.

[DirectXMan12]

Docs are up, and ready for review.

[claurence]

Kubernetes 1.13 is going to be a 'stable' release since the cycle is only 10 weeks. We encourage no big alpha features and only consider adding this feature if you have a high level of confidence it will make code slush by 11/09. Are there plans for this enhancement to graduate to alpha/beta/stable within the 1.13 release cycle? If not, can you please remove it from the 1.12 milestone or add it to 1.13?

We are also now encouraging that every new enhancement aligns with a KEP. If a KEP has been created, please link to it in the original post. Please take the opportunity to develop a KEP

[jbartosik]

This is in 1.12 I just forgot to close the issue.

[kacole2]

@jbartosik has this gone Stable/GA? We don't want to close the issue until it has graduated until that point. We can keep it open if it's still in beta
/milestone clear

[justaugustus]

/reopen

[k8s-ci-robot]

@justaugustus: Reopening this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jbartosik]

This was merged into HPA. This has the same status as HPA (beta) and will go GA with the rest of HPA v2. So I think it makes sense to have only one issue for tracking transition to GA (#117).

[jbartosik]

@justaugustus @kacole2 @claurence what should I do with this issue? Is it ok to close it and track going to GA in issue 117?

[kacole2]

@jbartosik i think closing and tracking with #117 is a better way to go unless @justaugustus has any objections

[jbartosik]

@justaugustus I'm closing this and plan to track this going GA in issue 117 together with the rest of HPA v2.

If you wold prefer me to handle this differently please reopen and explain what I should do.