Update kubadm ha installation for 1.12 #10264

chuckha · 2018-09-10T19:49:42Z

Signed-off-by: Chuck Ha ha.chuck@gmail.com

/cc @detiber
/assign @Bradamant3

Signed-off-by: Chuck Ha <ha.chuck@gmail.com>

k8sio-netlify-preview-bot · 2018-09-10T19:49:46Z

Deploy preview for kubernetes-io-vnext-staging processing.

Built with commit ded081e

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5ba3e8c5b312742dac8f2034

timothysc · 2018-09-10T20:03:05Z

/assign @fabriziopandini

/cc @kubernetes/sig-cluster-lifecycle-pr-reviews

timothysc

/approve

But we should independently walk all the steps. We found out the hard way last cycle that a typo can cause issues.

timothysc · 2018-09-10T20:28:34Z

/assign @timothysc

fabriziopandini · 2018-09-11T07:26:40Z

content/en/docs/setup/independent/high-availability.md

@@ -250,9 +250,9 @@ done
            # This CIDR is a calico default. Substitute or remove for your CNI provider.
            podSubnet: "192.168.0.0/16"

-1.  Replace `x` in `kubernetesVersion: v1.11.x` with the latest available version. 
+1.  Replace `x` in `kubernetesVersion: v1.11.x` with the latest available version.


i spoke with sig-docs about possible means for how to automate such versions with a variable, but the outcome of this discussion was that having such variables in the website framework are not that easy to add.

BTW i think this can be replaced with just kubernetesVersion: stable. kubeadm can handle that.
@fabriziopandini @chuckha WDYT?

Oh this is for the stacked masters part of the document. I didn't go through those instructions so I didn't modify any of it.

stable could work, but it would require some extra thought on the part of the user. For example, the folks testing these instructions would have to remember to change stable to 1.12.0-beta.2 since stable is currently 1.11.3.

if we use stable we can have a single comment on top in the lines of
replace "stable" with the version you want to use - e.g. 1.12.0-beta.2.

this doesn't require per cycle maintenance.

I made this change below, I'm leaving the stacked control planes untouched.

I'm leaving the stacked control planes untouched.

hm, is there a reason for that?
i think we can replace all v1.11.x instances with stable in the document.

to keep the changes small and focused on one section and to let @detiber make updates to the stacked control planes section without having to debug any of my changes.

fabriziopandini · 2018-09-11T07:47:36Z

@chuckha I wil test this asap.
Not sure it is the right time for this, but I think that it should be convenient for us change the stacked scenario an make it more similar to the external scenario:

On first master

Create an external etcd with phases
Init using the stacked etcd as external etcd

On secondary control-plane

join --control-plane
Create a secondary etcd with kubeadm phases and join it to the etcd cluster using kubectl exec

In this way the init and join action should be the same in both scenarios
WDYT?

neolit123 · 2018-09-13T00:48:10Z

content/en/docs/setup/independent/high-availability.md

+
+        tar -xzf etcd-pki.tar.gz -C /etc/kubernetes/pki --strip-components=3
+
+1.  Create a `kubeadm-config.yaml`:

        apiVersion: kubeadm.k8s.io/v1alpha2


the document needs a v1alpha3 bump.
and also MasterConfiguration -> [some-other-configuration]

i'm about to send a PR that fixes this for some other pages.

Yeah...I tried to get a v1alpha3 configuration working but failed. I'll revisit this since I definitely want to use the newest stuff. We're already bound to 1.12 features due to instructions using --control-plane so why not use v1alpha3 as well.

zparnold · 2018-09-13T05:16:21Z

@neolit123 Where does this stand then? Can I merge this and then follow it with your updates?

neolit123 · 2018-09-13T05:23:35Z

@zparnold

Where does this stand then? Can I merge this and then follow it with your updates?

i'm hoping that @chuckha can make the amends here.

zparnold · 2018-09-13T06:02:40Z

Ok! :) . Sounds good.

…

On Wed, Sep 12, 2018 at 10:23 PM Lubomir I. Ivanov ***@***.***> wrote: @zparnold <https://github.com/zparnold> Where does this stand then? Can I merge this and then follow it with your updates? i'm hoping that @chuckha <https://github.com/chuckha> can make the amends here. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10264 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE81SIKisRxcMzS6Dp8ZM02j02WCtnbPks5uaevZgaJpZM4WiD20> .

chuckha · 2018-09-17T14:24:20Z

cc @detiber regarding @fabriziopandini's comment about stacked control plane update above

Signed-off-by: Chuck Ha <ha.chuck@gmail.com>

detiber · 2018-09-18T19:15:22Z

@fabriziopandini By configuring the stacked control plane nodes using external etcd, it then complicates the further lifecycle management of the cluster, since the etcd deployment then needs to be managed externally going forward. I'm still working on the upgrade instructions, but here are some rough notes around the current upgrade process: https://gist.github.com/detiber/98742a1db1151aa9a8aaaa3c219e061d

timothysc · 2018-09-18T21:37:48Z

content/en/docs/setup/independent/high-availability.md

@@ -139,11 +139,15 @@ different configuration.

 ### Bootstrap the first stacked control plane node

+{{< note >}}
+**Note**: Optionally replace `stable` with a different version of kubernetes such as `v1.12.0-beta.2` or `v1.12.0`.


nix the beta, we don't want that in a publicly facing doc.

timothysc · 2018-09-18T21:38:54Z

content/en/docs/setup/independent/high-availability.md

 1.  Create a `kubeadm-config.yaml` template file:

        apiVersion: kubeadm.k8s.io/v1alpha2
        kind: MasterConfiguration
-        kubernetesVersion: v1.11.x
+        kubernetesVersion: stable


shouldn't this alpha3?

Also I'd just put the v1.12.0 in there explicitly and remove the meta comment.

yeah, this is still WIP. rc1 is out so i'll finish this off today.

please see above discussions regarding exact version vs stable & meta comment. There will have to be a comment regardless, but this is the easier path imo.

Signed-off-by: Chuck Ha <ha.chuck@gmail.com>

chuckha · 2018-09-19T20:59:56Z

waiting for final updates from @detiber, whenever he says it's good to merge i'll squash it down to ~2 commits (since we both contributed) and then we'll be good to go.

neolit123 · 2018-09-19T21:08:39Z

btw, if you squash all into one github (and git) will preserve the authorship.

Bradamant3 · 2018-09-19T21:36:31Z

@zparnold I've got this one

Bradamant3 · 2018-09-19T21:50:33Z

content/en/docs/setup/independent/high-availability.md

@@ -139,15 +139,18 @@ different configuration.

 ### Bootstrap the first stacked control plane node

+{{< note >}}
+**Note**: Optionally replace `stable` with a different version of kubernetes such as `v1.12.0`.


s/kubernetes such as/Kubernetes, for example

Bradamant3 · 2018-09-19T21:51:43Z

content/en/docs/setup/independent/high-availability.md

+1.  Create a `kubeadm-config.yaml`:
+
+{{< note >}}
+**Note**: Optionally replace `stable` with a different version of kubernetes such as `v1.11.3`.


s/kubernetes such as/Kubernetes, for example

zparnold · 2018-09-20T16:13:19Z

@chuckha Have you seen @Bradamant3 's comments?

timothysc

/approve
/lgtm

Thx for the changes!

timothysc · 2018-09-20T17:28:06Z

content/en/docs/setup/independent/high-availability.md


 In the following example, replace `USER` and `CONTROL_PLANE_HOSTS` values with values
 for your environment.

 ```sh
+# Make a list of required etcd certificate files
+cat << EOF > etcd-pki-files.txt


fwiw I'll submit a PR later, but we could bash-fu several of these commands together.

This code is intentionally made simple to understand. I value readability to more over fewer complex commands in public documentation.

but if your bash-fu is more readable then by all means, submit away

Signed-off-by: Chuck Ha <ha.chuck@gmail.com>

timothysc

/lgtm

zparnold · 2018-09-20T20:45:03Z

/approve

k8s-ci-robot · 2018-09-20T20:45:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timothysc, zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [zparnold]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Update docs for fields allowed at root of CRD schema (#9973) * add plugin docs and examples (#10053) * docs update to promote TaintNodesByCondition to beta (#9626) * HPA Specificity Improvements (#8757) Updated the HPA docs to reference the `autoscaling/v2beta2` API version, and added documentation about the new fields. * adjust docs for pod ready++ (#10049) * Remove --cadvisor-port - has been deprecated since v1.10 (#10023) Change-Id: Id2a685473a243aef492a98ff450759f39e362557 * Add Documentation for Snapshot Feature (#9948) * Add documentation for snapshot feature * Update volume-snapshots.md * Add dry-run to api-concepts (#10033) * kubeadm-init: Update the offline support section (#10062) The update includes the following things (in mind with Kubernetes 1.12): - Remove the 1.8 image versions - Add the 1.10 image versions that were missing until now - Include a comment for the missing arch suffixes in 1.12 Signed-off-by: Rostislav M. Georgiev <rostislavg@vmware.com> * Say bye to `DynamicProvisioningScheduling` (#10157) The mentioned feature gate is now collapsed into `VolumeScheduling`. xref: kubernetes/kubernetes#67432 * Update ResourceQuota per PriorityClass state for 1.12 (#10229) * TokenRequest and TokenRequestProjection now beta (#10161) xref: kubernetes/kubernetes#67349 * Change feature state for kms provider to beta. (#10230) KMS Provider will be graduating to beta in v1.12, reflecting this change on the website. * coredns default (#10200) * Promote ShareProcessNamespace to beta in docs (#9996) * Add CoreDNS details to DNS Debug docs (#10201) * add coredns details * address nits, add query logging section * Update docs with topology aware dynamic provisioning (#9939) * Document topology aware volume binding feature * update for readability * Update storage-classes.md * comma splice * don't abbreviate * HPA Algorithm Information Improvements (#9780) * Update HPA docs with more algorithm details The HPA docs pointed to an out-of-date document for information on the algorithm details, which users were finding confusing. This sticks a section on the algorithm in the HPA docs instead, documenting both general behavior and corner cases. * Add glossary info, HPA docs on quantities People often ask about the quantity notation when working with the metrics APIs, so this adds a glossary entry on quantities (since they're used elsewhere in the system), and a short explantation in the HPA walkthough. * Information about HPA readiness and stabilization This adds information about the new changes to HPA readiness and stabilization from kubernetes/enhancements#591, and other minor changes that landed in Kubernetes 1.12. * Update horizontal-pod-autoscale.md * Audit 1.12 doc (#9953) * audit 1.12 document * remove legacy audit feature kubernetes/kubernetes#65862 * update feature gate doc * MountPropagation is now GA (#10090) * RuntimeClass documentation (#10102) * RuntimeClass documentation * Update runtime-class.md * Add documentation for Scheduler performance tuning (#10048) * Add documentation for Scheduler performance tuning * Update scheduler-perf-tuning.md * TTL controller for cleaning up finished resources (#10064) * TTL controller for cleaning up finished resources * Address comments * Update ttlafterfinished.md * Bump quota configuration api version (#10217) * Incremental update from master (#10278) * fix invalid href of cloud controller manager (#10240) * fix invalid yaml format (#10238) * update storage-limits doc with Azure disk part (#10224) update storage-limits doc with Azure disk part fix comments * Update kubelet-config-file.md (#10222) Update link to KubeletConfiguration struct. * fix a trivial misspelling (#10244) * Fix cassandra-statefulset.yaml indent level (#10243) * Mention minimum etcd versions (#10208) Source: https://groups.google.com/d/msg/kubernetes-dev/jMPA4JzKiY4/HIx2ugvLBAAJ * fix 404 error (#10250) * Small verb tweak (#10190) Present participle, ftw. * Add AnchorJS logic for header links (#10155) * Add AnchorJS JavaScript * Remove existing inpage_heading logic * Remove underline from anchor tags * Use single icon and add touch visibility * Use paragraph link icon for AnchorJS * Update Sass to use code formatting in docsContent headers * Update header size coverage to H3-H6 * fix broken link in kubefed.md (#10254) * Update the version numbers for the X-Remote-Extra- and Impersonate-Extra- key fixes (#9827) The fix was cherry picked into 1.11.3, 1.10.7, and 1.9.11: kubernetes/kubernetes#67162 kubernetes/kubernetes#67163 kubernetes/kubernetes#67164 * fix typo (#10168) * fix typo * addressing comments. * Update setup-ha-etcd-with-kubeadm.md * fix typos (#10252) * fix description of contribute guide (#10253) * describe truncate feature about advanced audit (#10236) * describe truncate feature about advanced audit * Update audit.md * docs update to promote ScheduleDaemonSetPods to beta (#9923) * Dynamic volume limit updates for 1.12 (#10211) * add a placeholder commit * Update docs for csi volume limits * Update storage-limits.md * Add "MayRunAs" value among other GroupStrategies (#9888) * Add CoreDNS details to the customize DNS doc (#10228) * Add CoreDNS details to the customize DNS doc Rewrite the document to include more details about CoreDNS, since it's now the default from v1.12 * Address comments * Improve doc wording * Fix link * Update dns-custom-nameservers.md * Update dns-custom-nameservers.md * Fix secrets docs in 1.12 branch (#10056) * Fix secrets docs * Update secret.md * Revert CoreDNS Docs (#10319) * Revert "Add CoreDNS details to DNS Debug docs (#10201)" This reverts commit 462817a. * Revert "Add CoreDNS details to the customize DNS doc (#10228)" This reverts commit e7319ee. * Revert "coredns default (#10200)" This reverts commit 698e93b. * Add CRI installation instructions page Added cri-installation page with CRI installation instructions Referenced it from kubeadm-init and install-kubeadm pages. * kubeadm: update API types documentation for 1.12 (#10283) v1alpha2 -> v1alpha3 MasterConfiguration -> [new-api-types] * TokenRequest feature documentation (#10295) * AdvancedAuditing is now GA (#10156) xref: kubernetes/kubernetes#65862 `AdvancedAuditing` feature is GA in 1.12. This PR adjusts the related docs. * update runtime-class.md (#10332) * update runtime-class.md * Update runtime-class.md * Document cross-authorizer permissions for creating RBAC roles (#10015) * Document cross-authorizer permissions for creating RBAC roles * Update rbac.md * kubeadm: update authored content for 1.12 (reference docs and cluster creation) (#10348) * kubeadm: update authored content in reference docs for 1.12 * kubeadm: add time frame in create-cluster-kubeadm for 1.12 * add AllowedProcMountTypes and ProcMountType to docs (#9911) Signed-off-by: Jess Frazelle <acidburn@microsoft.com> * kubeadm: add new command line reference (#10306) Add: - placeholder files - include place holder files - include "renew" sub command - add missing tabs for "alpha phase kubelet" * Documenting SCTP support in Kubernetes (#10279) * Documenting SCTP support in Kubernetes Service, Endpoint, NetworkPolicy and Pod * Updates based on comments on the PR * kubectl expose update with SCTP support * Updated according to comments in the PR * Revert "kubectl expose update with SCTP support" This reverts commit 0d5a1e6. * TLS Bootstrap and Server Cert Rotation feature documentation (#10232) * TokenRequest feature documentation * line wrapping to make review not insane * update content for GA without major refactor * Update kubelet-tls-bootstrapping.md * Add clarifications for volume snapshots (#10296) * Update kubadm ha installation for 1.12 (#10264) * Update kubadm ha installation for 1.12 Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * update stable version Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * Update stacked control plane for v1.12 (#2) * use v1alpha3 Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * more v1alpha3 (#4) * updates Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * Document how to run in-tree cloud providers with kubeadm (#10357) Change-Id: Iab6b996a830503d74a6eb0c507c5f8ca7a39235b * kubeadm reference doc for release 1.12 (#10359) * Revert "Revert "Add CoreDNS details to DNS Debug docs (#10201)"" This reverts commit bb30f4d. * Revert "Revert "Add CoreDNS details to the customize DNS doc (#10228)"" This reverts commit bc23d45. * Revert "Revert "coredns default (#10200)"" This reverts commit 7f4350d. * add missing instruction for ha guide (#10374) Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * kubeadm - Ha upgrade updates (#10340) * Update HA upgrade docs * Adds external etcd HA upgrade guide Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * copyedit * more edits * add runasgroup in psp (#10076) * update KubeletPluginsWatcher feature gate (#10205) * generated 1.12 docs * Building Multi-arch images with Manifests (#10379) In 1.12, a variety of images used in a typical kubernetes installation have started to using manifests to better support environments with arm or ppc64le architectures. For example all images used with kubeadm by default have manifests, another would be all the tests in the conformance test suite. Here we capture the best practices for everyone to start using manifests in their own workflows. Change-Id: I5ba4c5fe55ffc9486a8251760f3352be4f2e1494 * Upgrade docs for v1.12 (#10344) * generated assets and docs * remove 1.7 * update 1.12 * update plugin documentation under docs>tasks>extend-kubectl (#10259) * update plugin documentation under docs>tasks>extend-kubectl * Update kubectl-plugins.md

Update kubadm ha installation for 1.12

1496d5f

Signed-off-by: Chuck Ha <ha.chuck@gmail.com>

k8s-ci-robot assigned Bradamant3 Sep 10, 2018

k8s-ci-robot requested a review from detiber September 10, 2018 19:49

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 10, 2018

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 10, 2018

k8s-ci-robot assigned fabriziopandini Sep 10, 2018

k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Sep 10, 2018

timothysc approved these changes Sep 10, 2018

View reviewed changes

k8s-ci-robot assigned timothysc Sep 10, 2018

fabriziopandini reviewed Sep 11, 2018

View reviewed changes

neolit123 reviewed Sep 13, 2018

View reviewed changes

update stable version

c3ca07a

Signed-off-by: Chuck Ha <ha.chuck@gmail.com>

fabriziopandini mentioned this pull request Sep 18, 2018

Checklist for kubeadm join --control-plane implementation kubernetes/kubeadm#751

Closed

11 tasks

Update stacked control plane for v1.12 (#2)

b103c02

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 18, 2018

timothysc suggested changes Sep 18, 2018

View reviewed changes

use v1alpha3

73fce39

Signed-off-by: Chuck Ha <ha.chuck@gmail.com>

more v1alpha3 (#4)

c7af8a9

Bradamant3 reviewed Sep 19, 2018

View reviewed changes

Bradamant3 added this to the 1.12 milestone Sep 19, 2018

timothysc reviewed Sep 20, 2018

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2018

timothysc mentioned this pull request Sep 20, 2018

Upgrade path for Stacked HA Controller Nodes kubernetes/kubeadm#948

Closed

updates

ded081e

Signed-off-by: Chuck Ha <ha.chuck@gmail.com>

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2018

timothysc approved these changes Sep 20, 2018

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2018

k8s-ci-robot merged commit ce69248 into kubernetes:release-1.12 Sep 20, 2018

timothysc mentioned this pull request Sep 20, 2018

HA documentation update kubernetes/kubeadm#1044

Closed

Update kubadm ha installation for 1.12 #10264

Update kubadm ha installation for 1.12 #10264

Conversation

chuckha commented Sep 10, 2018

k8sio-netlify-preview-bot commented Sep 10, 2018 • edited Loading

timothysc commented Sep 10, 2018

timothysc left a comment

Choose a reason for hiding this comment

timothysc commented Sep 10, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fabriziopandini commented Sep 11, 2018

Choose a reason for hiding this comment

neolit123 Sep 13, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zparnold commented Sep 13, 2018

neolit123 commented Sep 13, 2018

zparnold commented Sep 13, 2018 via email

chuckha commented Sep 17, 2018 • edited Loading

detiber commented Sep 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chuckha commented Sep 19, 2018

neolit123 commented Sep 19, 2018

Bradamant3 commented Sep 19, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zparnold commented Sep 20, 2018

timothysc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

timothysc left a comment

Choose a reason for hiding this comment

zparnold commented Sep 20, 2018

k8s-ci-robot commented Sep 20, 2018

k8sio-netlify-preview-bot commented Sep 10, 2018 •

edited

Loading

neolit123 Sep 13, 2018 •

edited

Loading

chuckha commented Sep 17, 2018 •

edited

Loading