Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work in progress - Split Control Plane and Dataplane #11260

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Apr 14, 2024

No description provided.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 14, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Apr 14, 2024
Copy link

netlify bot commented Apr 14, 2024

Deploy Preview for kubernetes-ingress-nginx ready!

Name Link
🔨 Latest commit 0a0d4aa
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/66382c7698b79f000841b354
😎 Deploy Preview https://deploy-preview-11260--kubernetes-ingress-nginx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/docs size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 14, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 14, 2024
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me know when is ready for review

@strongjz strongjz added this to the release-2.0 milestone Apr 16, 2024
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. area/helm Issues or PRs related to helm charts size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 23, 2024
@rikatz
Copy link
Contributor Author

rikatz commented May 6, 2024

First pass of e2e:

Summarizing 71 Failures:
  [FAIL] [Setting] access-log [BeforeEach] access-log-path use the specified configuration
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Setting] nginx-configuration [It] start nginx with default configuration
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/deployment.go:387
  [FAIL] [Annotations] canary-* [BeforeEach] when canary is created should route requests to the correct upstream if mainline ingress is created after the canary ingress
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Flag] ingress-class With specific ingress-class flags [It] should ignore Ingress with no class and accept the correctly configured Ingresses
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:283
  [FAIL] [Annotations] affinity session-cookie-name [BeforeEach] should change cookie name on ingress definition change
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Setting] configmap server-snippet [BeforeEach] should add global server-snippet and drop annotations per admin config
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Setting] aio-write [BeforeEach] should be disabled when setting is false
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Setting] gzip [BeforeEach] should set gzip_types to text/html
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Setting] [Security] global-auth-url [BeforeEach] when global external authentication is configured should return status code 401 when request any protected service
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Flag] ingress-class [BeforeEach] Without IngressClass Cluster scoped Permission should watch Ingress with correct annotation
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Setting] access-log [BeforeEach] stream-access-log-path use the specified configuration
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [TIMEDOUT] [Annotations] rewrite-target use-regex enable-rewrite-log [BeforeEach] should use correct longest path match
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:96
  [FAIL] [Setting] [Security] global-auth-url [BeforeEach] when global external authentication is configured should add custom error page when global-auth-signin url is configured
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Flag] custom HTTP and HTTPS ports [BeforeEach] with a TLS enabled ingress should set X-Forwarded-Port header to 443
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Setting] log-format-* [BeforeEach] Check log-format-escape-json and log-format-escape-none should disable the log-format-escape-json
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Setting] gzip [BeforeEach] should set gzip_disable to msie6
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [TCP] tcp-services [BeforeEach] should expose a TCP service
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Setting] proxy-send-timeout [BeforeEach] should set valid proxy send timeouts using configmap values
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Annotations] from-to-www-redirect [BeforeEach] should redirect from www HTTP to HTTP
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Flag] ingress-class [BeforeEach] Without IngressClass Cluster scoped Permission should ignore Ingress with only IngressClassName
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Annotations] auth-* [BeforeEach] when external authentication is configured should return status code 200 when signed in
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Setting] [Load Balancer] load-balance [It] should apply the configmap load-balance setting
  /go/src/k8s.io/ingress-nginx/test/e2e/loadbalance/configmap.go:49
  [FAIL] [Annotations] auth-* cookie set by external authentication server [BeforeEach] user retains cookie by default
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/deployment.go:387
  [TIMEDOUT] [Annotations] cors-* [BeforeEach] should allow - matching origin+port with wildcard origin
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:96
  [FAIL] [Service] Type ExternalName [BeforeEach] should return status 502 for service type=ExternalName with an invalid host
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Setting] use-proxy-protocol [BeforeEach] should respect port passed by the PROXY Protocol
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Setting] gzip [BeforeEach] should be enabled with default settings
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Annotations] auth-* [BeforeEach] cookie set by external authentication server user with annotated ingress retains cookie if upstream returns error status code
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Shutdown] ingress controller [BeforeEach] should shutdown in less than 60 secons without pending connections
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Annotations] x-forwarded-prefix [BeforeEach] should set the X-Forwarded-Prefix to the annotation value
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Setting] [SSL] TLS protocols, ciphers and headers) [BeforeEach] should configure TLS protocol setting cipher suite
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Annotations] auth-* [BeforeEach] with invalid auth-url should deny whole location should add error to the config
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Annotations] canary-* [BeforeEach] Single canary Ingress should not use canary as a catch-all server
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [TIMEDOUT] [Annotations] preserve-trailing-slash [BeforeEach] should allow preservation of trailing slashes
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:96
  [FAIL] [Lua] dynamic configuration [BeforeEach] when only backends change handles an annotation change
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Flag] ingress-class [BeforeEach] With default ingress class config should serve Ingress when class is added
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Lua] dynamic certificates [BeforeEach] given an ingress with TLS correctly configured picks up the updated certificate without reloading
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Annotations] auth-tls-* [BeforeEach] should validate auth-tls-verify-client
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Setting] log-format-* Check log-format-upstream with log-format-escape-json and log-format-escape-none [It] log-format default escape
  /go/src/k8s.io/ingress-nginx/test/e2e/settings/log-format.go:123
  [FAIL] [Flag] disable-catch-all [It] should delete Ingress updated to catch-all
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/httpexpect/reporter.go:47
  [FAIL] [Annotations] service-upstream [BeforeEach] when enabling in the configmap should use the Service Cluster IP and Port
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [SSL] [Flag] default-ssl-certificate [BeforeEach] uses default ssl certificate for host based ingress when configured certificate does not match host
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/ssl.go:149
  [TIMEDOUT] [Flag] disable-catch-all [BeforeEach] should ignore catch all Ingress with backend
  /go/src/k8s.io/ingress-nginx/test/e2e/settings/disable_catch_all.go:36
  [FAIL] Configure Opentelemetry [BeforeEach] should exists opentelemetry_operation_name directive when is configured
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Setting] [Security] global-auth-url [BeforeEach] cookie set by external authentication server user with global-auth-always-set-cookie key in configmap retains cookie if upstream returns error status code
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Annotations] Annotation - limit-connections [BeforeEach] should limit-connections
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/deployment.go:387
  [FAIL] [Annotations] service-upstream when using the default value (false) and enabling in the annotations [It] should use the Service Cluster IP and Port
  /go/src/k8s.io/ingress-nginx/test/e2e/annotations/serviceupstream.go:63
  [FAIL] [Annotations] server-alias [BeforeEach] should return status code 200 for host 'foo' and 'bar'
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Setting] reuse-port [BeforeEach] reuse port should be disabled
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] global-options [BeforeEach] should have worker_rlimit_nofile option
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [metrics] exported prometheus metrics [BeforeEach] exclude socket request metrics are present
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Annotations] auth-* [BeforeEach] with invalid auth-url should deny whole location should return 503 (location was denied)
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Annotations] affinity session-cookie-name [BeforeEach] does not set the path to / on the generated cookie if there's more than one rule referring to the same backend
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Annotations] proxy-* [BeforeEach] should set valid proxy timeouts
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Setting] log-format-* [BeforeEach] Check log-format-upstream with log-format-escape-json and log-format-escape-none log-format-escape-json enabled
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Annotations] modsecurity owasp [BeforeEach] should disable default modsecurity conf setting when modsecurity-snippet is specified
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] Debug CLI [BeforeEach] should list the backend servers
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Flag] disable-sync-events [BeforeEach] should create sync events (default)
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Setting] keep-alive keep-alive-requests [BeforeEach] Check the upstream keep alive should set the request count to upstream server through one keep alive connection
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Setting] Geoip2 [BeforeEach] should include geoip2 line in config when enabled and db file exists
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Annotations] satisfy [BeforeEach] should configure satisfy directive correctly
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [TIMEDOUT] [SSL] [Flag] default-ssl-certificate [BeforeEach] uses default ssl certificate for catch-all ingress
  /go/src/k8s.io/ingress-nginx/test/e2e/settings/default_ssl_certificate.go:42
  [FAIL] [Setting] Geoip2 [BeforeEach] should only allow requests from specific countries
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Service] Type ExternalName [It] should update the external name after a service update
  /go/src/k8s.io/ingress-nginx/test/e2e/servicebackend/service_externalname.go:336
  [FAIL] [Annotations] upstream-hash-by-* [BeforeEach] should connect to the same pod
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Flag] disable-sync-events [BeforeEach] should not create sync events
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Annotations] configuration-snippet [BeforeEach] drops snippet more_set_header in all locations if disabled by admin
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] global-options [BeforeEach] should have worker_rlimit_nofile option and be independent on amount of worker processes
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] [Annotations] proxy-* [BeforeEach] should set proxy_redirect to off
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [FAIL] Debug CLI [BeforeEach] should get information for a specific backend server
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:158
  [TIMEDOUT] [Annotations] cors-* [BeforeEach] should expose headers for cors
  /go/src/k8s.io/ingress-nginx/test/e2e/framework/framework.go:96

Ran 264 of 435 Specs in 4546.853 seconds
FAIL! - Suite Timeout Elapsed -- 193 Passed | 71 Failed | 63 Flaked | 0 Pending | 171 Skipped

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 6, 2024

@rikatz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-ingress-nginx-boilerplate 0a0d4aa link true /test pull-ingress-nginx-boilerplate

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/docs area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants