Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Do all boilerplate checks in 1 python call
It's just a little bit faster..... BEFORE: $ time hack/verify-boilerplate.sh real 0m9.378s user 0m3.405s sys 0m13.906s AFTER: $ time hack/verify-boilerplate.sh real 0m0.181s user 0m0.114s sys 0m0.068s
- Loading branch information
Showing
4 changed files
with
117 additions
and
75 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
#!/usr/bin/env python | ||
|
||
# Copyright 2015 The Kubernetes Authors All rights reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
from __future__ import print_function | ||
|
||
import json | ||
import mmap | ||
import os | ||
import re | ||
import sys | ||
|
||
def PrintError(*err): | ||
print(*err, file=sys.stderr) | ||
|
||
def file_passes(filename, extention, ref, regex): | ||
try: | ||
f = open(filename, 'r') | ||
except: | ||
return False | ||
|
||
data = f.readlines() | ||
|
||
# remove build tags from the top of Go file | ||
if extention == "go": | ||
while data[0] != "/*\n": | ||
data = data[1:] | ||
|
||
# if our test file is smaller than the reference it surely fails! | ||
if len(ref) > len(data): | ||
return False | ||
|
||
# trim our file to the same number of lines as the reference file | ||
data = data[:len(ref)] | ||
|
||
# Replace all occurances of the regex "2015" with "2014" | ||
for i, d in enumerate(data): | ||
(data[i], found) = regex.subn( '2014', d) | ||
if found != 0: | ||
break | ||
|
||
# if we don't match the reference at this point, fail | ||
if ref != data: | ||
return False | ||
|
||
return True | ||
|
||
def main(): | ||
if len(sys.argv) < 3: | ||
PrintError("usage: %s extension FILENAME [FILENAMES]" % sys.argv[0]) | ||
return False | ||
|
||
basedir = os.path.dirname(os.path.abspath(__file__)) | ||
|
||
extention = sys.argv[1] | ||
# argv[0] is the binary, argv[1] is the extension (go, sh, py, whatever) | ||
filenames = sys.argv[2:] | ||
|
||
ref_filename = basedir + "/boilerplate." + extention + ".txt" | ||
try: | ||
ref_file = open(ref_filename, 'r') | ||
except: | ||
# No boilerplate template is success | ||
return True | ||
ref = ref_file.readlines() | ||
|
||
# dates can be 2014 or 2015, company holder names can be anything | ||
p = re.compile( '(2014|2015)' ) | ||
|
||
for filename in filenames: | ||
if not file_passes(filename, extention, ref, p): | ||
print(filename, file=sys.stdout) | ||
|
||
if __name__ == "__main__": | ||
sys.exit(main()) |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters