Skip to content

Commit

Permalink
Check e2e code for avoiding circular dependency
Browse files Browse the repository at this point in the history
Core e2e test framework(test/e2e/framework) should not import sub
e2e test frameworks (e.g. test/e2e/framework/auth) for avoiding
circular dependency.
This adds e2e code check for avoiding such circular dependency.
  • Loading branch information
Kenichi Omichi committed Aug 20, 2019
1 parent 8cf05f5 commit e82a0a0
Showing 1 changed file with 34 additions and 0 deletions.
34 changes: 34 additions & 0 deletions test/e2e/framework/.import-restrictions
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,40 @@
],
"ForbiddenPrefixes": []
},
{
"SelectorRegexp": "k8s[.]io/kubernetes/test/e2e/framework/",
"AllowedPrefixes": [],
"ForbiddenPrefixes": [
"k8s.io/kubernetes/test/e2e/framework/auth",
"k8s.io/kubernetes/test/e2e/framework/config",
"k8s.io/kubernetes/test/e2e/framework/deployment",
"k8s.io/kubernetes/test/e2e/framework/deviceplugin",
"k8s.io/kubernetes/test/e2e/framework/endpoints",
"k8s.io/kubernetes/test/e2e/framework/ginkgowrapper",
"k8s.io/kubernetes/test/e2e/framework/gpu",
"k8s.io/kubernetes/test/e2e/framework/ingress",
"k8s.io/kubernetes/test/e2e/framework/job",
"k8s.io/kubernetes/test/e2e/framework/kubelet",
"k8s.io/kubernetes/test/e2e/framework/lifecycle",
"k8s.io/kubernetes/test/e2e/framework/log",
"k8s.io/kubernetes/test/e2e/framework/metrics",
"k8s.io/kubernetes/test/e2e/framework/node",
"k8s.io/kubernetes/test/e2e/framework/perf",
"k8s.io/kubernetes/test/e2e/framework/pod",
"k8s.io/kubernetes/test/e2e/framework/podlogs",
"k8s.io/kubernetes/test/e2e/framework/providers",
"k8s.io/kubernetes/test/e2e/framework/psp",
"k8s.io/kubernetes/test/e2e/framework/replicaset",
"k8s.io/kubernetes/test/e2e/framework/resource",
"k8s.io/kubernetes/test/e2e/framework/service",
"k8s.io/kubernetes/test/e2e/framework/ssh",
"k8s.io/kubernetes/test/e2e/framework/statefulset",
"k8s.io/kubernetes/test/e2e/framework/testfiles",
"k8s.io/kubernetes/test/e2e/framework/timer",
"k8s.io/kubernetes/test/e2e/framework/viperconfig",
"k8s.io/kubernetes/test/e2e/framework/volume"
]
},
{
"SelectorRegexp": "k8s[.]io/kubernetes/third_party/",
"AllowedPrefixes": [
Expand Down

0 comments on commit e82a0a0

Please sign in to comment.