Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRI validation test #34040

Closed
yujuhong opened this issue Oct 4, 2016 · 11 comments
Closed

CRI validation test #34040

yujuhong opened this issue Oct 4, 2016 · 11 comments
Assignees
Labels
area/test priority/backlog Higher priority than priority/awaiting-more-evidence. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@yujuhong
Copy link
Contributor

yujuhong commented Oct 4, 2016

This was brought in the @kubernetes/sig-node meeting previously. I think having a CRI validation test is necessary eventually to qualify a new CRI shim and help CRI shim developers. It would be good to have such a test sooner than later.

Basically, we want a test framework and a set of tests to validate a CRI (grpc) server alone. For starters, we can just run tests locally on a machine where the grpc server runs. The test only needs to know the socket to talk to, and can perform the basic operations such as creating/deleting sandboxes/containers. Ideally, no runtime-specific bits should be included in the tests.

The CRI validation test should replace/subsume the existing runtime validation test (formerly known as automatic docker validation test: kubernetes/enhancements#57).

@kubernetes/sig-node, since we have multiple ongoing projects implementing CRI shims, this should be a sig-node community effort. If someone already has testing bits in their repository, you're welcome to donate such tests and/or harness. Volunteers to work on the CRI validation test is also welcome.

/cc @dchen1107 @Random-Liu @euank @yifan-gu @mrunalp

@yujuhong yujuhong added area/test priority/backlog Higher priority than priority/awaiting-more-evidence. sig/node Categorizes an issue or PR as relevant to SIG Node. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Oct 4, 2016
@mrunalp
Copy link
Contributor

mrunalp commented Oct 4, 2016

We have added a testing framework to cri-o using bats that is working quite well for us so far. We would be glad to share those tests. PTAL https://github.com/kubernetes-incubator/cri-o/blob/master/test/ctr.bats as an example.

@feiskyer
Copy link
Member

feiskyer commented Oct 7, 2016

Frakti has setup a framework for cri validation: https://github.com/kubernetes/frakti/tree/master/test/e2e, it reuses same e2e framework from kubernetes.

@Random-Liu
Copy link
Member

Frakti has setup a framework for cri validation: https://github.com/kubernetes/frakti/tree/master/test/e2e, it reuses same e2e framework from kubernetes.

What test are you running? :)

@feiskyer
Copy link
Member

feiskyer commented Oct 7, 2016

@Random-Liu Currently sandbox and image APIs in CRI are tested. Container apis will be added later.

@resouer
Copy link
Contributor

resouer commented Oct 12, 2016

+1 for https://github.com/kubernetes/frakti/tree/master/test/e2e which is using k8s e2e framework CCed zjuers who created them in frakti @xlgao-zju

@feiskyer
Copy link
Member

@xlgao-zju will work on this.

cc/ @resouer @yujuhong

@Random-Liu
Copy link
Member

@feiskyer @resouer Nice.
@xlgao-zju Thanks for your help!

@xlgao-zju
Copy link
Contributor

I will try my best to get this job done. :)

@yujuhong yujuhong removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Oct 12, 2016
@feiskyer
Copy link
Member

The feature has been moved to cri-tools, and kubernetes/enhancements#292.

@feiskyer
Copy link
Member

Closing it here.

@feiskyer
Copy link
Member

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test priority/backlog Higher priority than priority/awaiting-more-evidence. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

No branches or pull requests

7 participants