Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify e2e.go #74353

Closed
pohly opened this issue Feb 21, 2019 · 7 comments · Fixed by #79909
Closed

simplify e2e.go #74353

pohly opened this issue Feb 21, 2019 · 7 comments · Fixed by #79909
Assignees
@retpolanne
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@pohly
Copy link
Contributor

pohly commented Feb 21, 2019

What would you like to be added:

#66649 and its PR #68483 made it possible to use test/e2e/framework outside of Kubernetes. But projects doing that (like https://github.com/intel/pmem-CSI/blob/d4bd9086d742701ba5b5fe10d413a2ed79a8fad4/test/e2e/e2e.go or https://github.com/intel/oim/blob/799b79eb01b4471a715f3f12b4c199a7c055c8ef/test/e2e/e2e.go) still need to copy a significant chunk of code. It would be better to move more of that code into the test/e2e/framework itself where it then can be reused.

One thing that has to be kept in mind is that the set of dependencies of the framework should not be increased by this.

Why is this needed:

Simplifies the writing of a custom E2E test suite.
@pohly pohly added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 21, 2019
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 21, 2019
@pohly
Copy link
Contributor Author

pohly commented Feb 21, 2019

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 21, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 22, 2019
@pohly
Copy link
Contributor Author

pohly commented May 24, 2019

/remove-lifecycle stale
/help-wanted

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 24, 2019
@pohly
Copy link
Contributor Author

pohly commented May 24, 2019

/help

@k8s-ci-robot
Copy link
Contributor

@pohly:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label May 24, 2019
@retpolanne
Copy link
Contributor

@pohly I would like to work on this issue.

@pohly
Copy link
Contributor Author

pohly commented Jul 1, 2019

I would like to work on this issue.

Thanks for the offer. Let's see whether I can assign it to you...

/assign @vinicyusmacedo

If you want to discuss it further, feel free to reach out to the folks currently maintaining the E2E framework (the testing-commons sub-project of SIG-testing, see https://github.com/kubernetes/community/tree/master/sig-testing#subprojects). I'm less active there at the moment.

@retpolanne retpolanne mentioned this issue Jul 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@retpolanne retpolanne

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moving e2e boilerplate to separate functions
4 participants
@pohly @retpolanne @k8s-ci-robot @fejta-bot