Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exec credential provider: don't run exec plugin with basic auth #102175

Merged
merged 1 commit into from May 21, 2021
Merged

exec credential provider: don't run exec plugin with basic auth #102175

merged 1 commit into from May 21, 2021

Conversation

ankeesler
Copy link
Contributor

If a user specifies basic auth, then apply the same short circuit logic
that we do for bearer tokens (see comment).

Signed-off-by: Andrew Keesler akeesler@vmware.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

None.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

/sig auth

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/auth Categorizes an issue or PR as relevant to SIG Auth. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels May 20, 2021
@ankeesler ankeesler mentioned this pull request May 20, 2021
Closed
@enj
Copy link
Member

enj commented May 20, 2021

/triage accepted
/assign

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 20, 2021
@enj enj added this to Needs Triage PRs in SIG Auth Old May 20, 2021
@enj enj moved this from Needs Triage PRs to In Review (v1.22) in SIG Auth Old May 20, 2021
@enj
Copy link
Member

enj commented May 20, 2021

I would like to see a new test in test/cmd/authentication.sh as well.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 21, 2021
@ankeesler
Copy link
Contributor Author

cmd test added: b73b5547832578b8b98cec8168e11c1773307cbd

note that this pr will start failing once #102152 merges, since a metrics test assertion from that pr is now incorrect.

@ankeesler ankeesler force-pushed the exec-plugin-with-basic-auth branch from b73b554 to 859d87f Compare May 21, 2021 17:08
@enj
Copy link
Member

enj commented May 21, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2021
@ankeesler
exec credential provider: don't run exec plugin with basic auth
9dee2b9 
If a user specifies basic auth, then apply the same short circuit logic
that we do for bearer tokens (see comment).

Signed-off-by: Andrew Keesler <akeesler@vmware.com>
@ankeesler ankeesler force-pushed the exec-plugin-with-basic-auth branch from 859d87f to 9dee2b9 Compare May 21, 2021 17:51
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2021
@enj
Copy link
Member

enj commented May 21, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2021
@deads2k
Copy link
Contributor

deads2k commented May 21, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankeesler, deads2k, enj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2021
@k8s-ci-robot k8s-ci-robot merged commit 863e22c into kubernetes:master May 21, 2021
SIG Auth Old automation moved this from In Review (v1.22) to Closed / Done May 21, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@enj enj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG Auth Old
Closed / Done
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ankeesler @enj @deads2k @k8s-ci-robot