Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support Azure data disk volume #29836

Merged
merged 1 commit into from Aug 24, 2016
Merged

support Azure data disk volume #29836

merged 1 commit into from Aug 24, 2016

Conversation

rootfs
Copy link
Contributor

@rootfs rootfs commented Jul 31, 2016 •
edited by k8s-oncall

This is a WIP of supporting azure data disk volume. Will add test and dynamic provisioning support once #29006 is merged

replace #25915
fix #23259

@kubernetes/sig-storage
@colemickens @brendandburns

This change is Reviewable

@rootfs rootfs mentioned this pull request Jul 31, 2016
Closed
@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels Jul 31, 2016
@rootfs rootfs force-pushed the azuredd branch 8 times, most recently from 07ff4bf to c9d26a7 Compare August 1, 2016 01:20
@brendandburns brendandburns self-assigned this Aug 1, 2016
@brendandburns
Copy link
Contributor

@thockin feel free to remove yourself if you want (though feel free to review if you want too ;)

@rootfs rootfs force-pushed the azuredd branch 3 times, most recently from 0203865 to c23fcb0 Compare August 1, 2016 15:10
brendandburns
brendandburns reviewed Aug 1, 2016
View reviewed changes
pkg/api/v1/types.go
FSType string `json:"fsType,omitempty" protobuf:"bytes,4,opt,name=fsType"`
// Defaults to false (read/write). ReadOnly here will force
// the ReadOnly setting in VolumeMounts.
ReadOnly bool `json:"readOnly,omitempty" protobuf:"varint,5,opt,name=readOnly"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be a protobuf boolean, not a varint?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems all bool use varint

saad-ali
saad-ali reviewed Aug 22, 2016
View reviewed changes
pkg/cloudprovider/providers/azure/azure_storage.go
vm, exists, err := az.getVirtualMachine(vmName)
if err != nil || !exists {
// if host doesn't exist, no need to detach
glog.Errorf("cannot find node %s", vmName)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this a warning and make it clear that detach is being skipped because of it.

@saad-ali saad-ali mentioned this pull request Aug 22, 2016
Closed
@saad-ali
Copy link
Member

@saad-ali I'd like to get this in prior to code freeze. so I'm LGTM-ing. If there are further concerns let's take care of them as follow on PRs.

Ack. Will create an tracking issue for follow-up.

#31186

@brendandburns
Copy link
Contributor

Thanks @saad-ali I will work to get those comments addressed asap.

@brendandburns
Copy link
Contributor

Reviewed 1 of 27 files at r3, 4 of 6 files at r4, 2 of 25 files at r7, 2 of 23 files at r8, 22 of 26 files at r9, 6 of 6 files at r10.
Review status: all files reviewed at latest revision, 20 unresolved discussions.

Comments from Reviewable

@brendandburns
Copy link
Contributor

Review status: all files reviewed at latest revision, 20 unresolved discussions.

pkg/volume/azure_dd/attacher.go, line 268 [r7] (raw file):

Previously, rootfs (Huamin Chen) wrote…

done

LGTM

Comments from Reviewable

@brendandburns
Copy link
Contributor

Review status: all files reviewed at latest revision, 20 unresolved discussions.

pkg/api/types.go, line 759 [r1] (raw file):

Previously, thockin (Tim Hockin) wrote…

Comment should explain what the field holds. This just restates the name. can you explain more?

LGTM

pkg/api/types.go, line 760 [r1] (raw file):

Previously, thockin (Tim Hockin) wrote…

Required? it's not omitempty, so I assume it is required.

LGTM

pkg/api/types.go, line 762 [r1] (raw file):

Previously, rootfs (Huamin Chen) wrote…

it is required

LGTM

Comments from Reviewable

@k8s-github-robot
Copy link

@rootfs PR needs rebase

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 23, 2016
@rootfs
support Azure data disk volume
dea4b02 
Signed-off-by: Huamin Chen <hchen@redhat.com>
@k8s-github-robot
Copy link

/lgtm cancel //PR changed after LGTM, removing LGTM. @brendandburns @jingxu97 @rootfs @saad-ali

@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 23, 2016
@k8s-bot
Copy link

k8s-bot commented Aug 23, 2016

GCE e2e build/test passed for commit dea4b02.

@rootfs
Copy link
Contributor Author

rootfs commented Aug 23, 2016

@brendandburns @saad-ali PR rebased. Can you tag it again? Thanks!

@brendandburns brendandburns added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Aug 23, 2016

GCE e2e build/test passed for commit dea4b02.

@k8s-github-robot k8s-github-robot mentioned this pull request Aug 23, 2016
Closed
@brendandburns
Copy link
Contributor

brendandburns commented Aug 24, 2016 •
edited

@k8s-bot node e2e test this issue: #31327

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Aug 24, 2016

GCE e2e build/test passed for commit dea4b02.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 3544f8a into kubernetes:master Aug 24, 2016
@rootfs rootfs mentioned this pull request Aug 24, 2016
Closed
@saad-ali saad-ali mentioned this pull request Aug 25, 2016
Closed
22 tasks
@rootfs
Copy link
Contributor Author

rootfs commented Sep 1, 2016 •
edited

@saad-ali followup PR on device path issue
#31366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brendandburns brendandburns

@saad-ali saad-ali

@jingxu97 jingxu97

Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

Provide support to attach a vhd as volume on Microsoft Azure
10 participants
@rootfs @brendandburns @thockin @saad-ali @jingxu97 @colemickens @k8s-bot @k8s-github-robot @childsb @googlebot