WIP: Kubernetes WebUI #5834

yllierop · 2015-03-24T04:48:05Z

I'd like to say thank-you to the following contributors for helping to create a new WebUI for Kubernetes.
@balavas, @bcbroussard, @brendandburns, @duftler, @craigmcl, @EranGabber, @jackgr, @jellzilla, @kenmoore, @kmerker, @preillyme, @rrmckinley, @unwornmoon.

This change is addressed in the following issue: #5789

googlebot · 2015-03-24T04:48:17Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot · 2015-03-24T05:42:08Z

CLAs look good, thanks!

googlebot · 2015-03-24T07:25:33Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot · 2015-03-24T07:58:55Z

CLAs look good, thanks!

yllierop · 2015-03-24T08:10:25Z

The most recent WIP was git merge --squash from https://github.com/kubernetes-ui/kubernetes-ui based on feedback from @roberthbailey

brendandburns · 2015-03-26T21:54:05Z

www/.travis.yml

@@ -0,0 +1,14 @@
+language: node_js


Please delete this file.

brendandburns · 2015-03-26T21:58:16Z

Comments about some redundant things to delete.

Thanks!
--brendan

yllierop · 2015-03-26T22:48:18Z

@brendandburns — I've removed the redundant items with things in our other docs directory.

yllierop · 2015-03-30T20:00:05Z

I'ved made this docker container for testing: https://github.com/kubernetes-ui/kubernetes-ui-docker

brendandburns · 2015-04-07T17:57:01Z

Will patch and try this out today. Thanks for the patience!

jackgr · 2015-04-07T19:17:19Z

Thanks, Brendan.

On Apr 7, 2015, at 10:57 AM, Brendan Burns notifications@github.com wrote:

Will patch and try this out today. Thanks for the patience!

—
Reply to this email directly or view it on GitHub.

yllierop · 2015-04-07T19:40:29Z

@brendanburns thanks for taking a look. Let me know if you need anything.

brendandburns · 2015-04-09T20:07:29Z

In order for this to actually run by default, you need to re-run ./hack/build-ui.sh and check in the generated files.

brendandburns · 2015-04-09T20:21:06Z

Also, even after I run build-ui.sh and go to https:///static/app/ the app doesn't work correctly (javascript errors)

yllierop · 2015-04-09T20:24:28Z

Okay I'll check in the generated files. Actually @brendanburns do you have some time to chat about one issue?

yllierop · 2015-04-09T21:10:55Z

@brendanburns I've got the same issue with this as I do with this version: https://github.com/kubernetes-ui/kubernetes-ui-docker/blob/master/docker-entrypoint.sh basically changing the values of www/app/assets/js/app.js to the correct values for the built cluster. Do you think that should happen in the build-ui.sh script? Also what do you think is the best way to handle username and passwords, e.g., "k8sApiServer": "https://admin:jxsffWYgwABFCBXG@104.154.65.114/api/v1beta2",, etc.

bcbroussard · 2015-04-13T23:41:44Z

@googlebot - As stated in an another pull request, I am covered under Google Corporate CLA "Kismatic, Inc." signed: Feb 09, 2015 21:17 PST - #5790

googlebot · 2015-04-13T23:50:37Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot · 2015-04-14T00:06:42Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

bcbroussard · 2015-04-14T00:34:38Z

@lavalamp Re: examples/rethinkdb/.DS_Store
Looks like it was added to master in another commit de25c0a. If I'm not mistaken, this PR is already removing the .DS_Store file.

googlebot · 2015-04-14T14:32:41Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot · 2015-04-14T16:02:16Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot · 2015-04-14T18:12:14Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

yllierop · 2015-04-14T18:13:06Z

@erictune can you confirm that @bcbroussard is currently covered under the Kismatic CLA.

lavalamp · 2015-04-14T22:04:33Z

@preillyme the googlebot is going off of the "new" mechanism, which is that it expects everyone covered by Kismatic's CLA to be in a group. Perhaps check that the email in the commit matches the email in the group?

yllierop · 2015-04-15T03:14:22Z

@lavalamp he's currently in https://groups.google.com/forum/#!members/kismatic so I'm not sure.

lavalamp · 2015-04-15T17:30:57Z

@preillyme I can't actually view the members there, so I'll take your word for it. Perhaps a different email was used in the individual commits than is in the group? :/

yllierop · 2015-04-17T17:15:26Z

@lavalamp I can confirm that the commit email address equals the CLA Google group. So I'm not sure. Is there any other way to check?

lavalamp · 2015-04-17T20:55:30Z

www/master/test/modules/controllers/cAdvisorController.spec.js

@@ -0,0 +1,3 @@
+'use strict';
+
+describe("cAdvisor controller", function() { it("should work as intended", function() {}); });


Are these test stubs?

@lavalamp yes they are stubs at this point.

lavalamp · 2015-04-17T23:28:26Z

OK I am going to give this another try.

lavalamp · 2015-04-18T01:14:05Z

Having unrelated issues w/ my cluster, will take this back up first thing monday.

googlebot · 2015-04-19T10:56:00Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

googlebot · 2015-04-19T10:58:00Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

googlebot · 2015-04-19T11:07:07Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

googlebot · 2015-04-19T11:24:22Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

lavalamp · 2015-04-20T18:10:31Z

www/README.md

+  `karma-chrome-launcher` should be automatically installed when
+  running `npm start`).
+* Go to the `www/master` directory, and run `karma start
+karma.conf.js`. The Karma configuration is defined in `karma.config.js`. The console should show the test results.


On my system, I get this. Please fix either the instructions or the tests :)

$ karma start karma.conf.js INFO [karma]: Karma v0.10.10 server started at http://localhost:9876/ INFO [launcher]: Starting browser Chrome WARN [watcher]: Pattern "/usr/local/google/home/dbsmith/code/k/src/github.com/GoogleCloudPlatform/third_party/ui/bower_components/angular/angular.js" does not match any file. WARN [watcher]: Pattern "/usr/local/google/home/dbsmith/code/k/src/github.com/GoogleCloudPlatform/third_party/ui/bower_components/angular-aria/angular-aria.js" does not match any file. WARN [watcher]: Pattern "/usr/local/google/home/dbsmith/code/k/src/github.com/GoogleCloudPlatform/third_party/ui/bower_components/angular-material/angular-material.js" does not match any file. WARN [watcher]: Pattern "/usr/local/google/home/dbsmith/code/k/src/github.com/GoogleCloudPlatform/third_party/ui/bower_components/angular-mocks/angular-mocks.js" does not match any file. WARN [watcher]: Pattern "/usr/local/google/home/dbsmith/code/k/src/github.com/GoogleCloudPlatform/third_party/ui/bower_components/angular-route/angular-route.js" does not match any file. WARN [watcher]: Pattern "/usr/local/google/home/dbsmith/code/k/src/github.com/GoogleCloudPlatform/third_party/ui/bower_components/angularjs-jasmine-matchers/dist/matchers.js" does not match any file. WARN [watcher]: Pattern "/usr/local/google/home/dbsmith/code/k/src/github.com/GoogleCloudPlatform/third_party/ui/bower_components/hammerjs/hammer.js" does not match any file. WARN [watcher]: Pattern "/usr/local/google/home/dbsmith/code/k/src/github.com/GoogleCloudPlatform/third_party/ui/bower_components/lodash/dist/lodash.js" does not match any file. WARN [watcher]: Pattern "/usr/local/google/home/dbsmith/code/k/src/github.com/GoogleCloudPlatform/kubernetes/www/master/components/**/test/**/*.js" does not match any file. WARN [watcher]: Pattern "/usr/local/google/home/dbsmith/code/k/src/github.com/GoogleCloudPlatform/kubernetes/www/app/shared/**/*.js" does not match any file. INFO [Chrome 42.0.2311 (Linux)]: Connected on socket 6iS3nwjNk5zArWmKBQoK Chrome 42.0.2311 (Linux) ERROR Uncaught ReferenceError: angular is not defined at /usr/local/google/home/dbsmith/code/k/src/github.com/GoogleCloudPlatform/kubernetes/www/app/assets/js/app.js:8 Chrome 42.0.2311 (Linux): Executed 0 of 0 ERROR (0.238 secs / 0 secs)

lavalamp · 2015-04-21T01:22:58Z

Closing; superseded by #7056

googlebot added the cla: no label Mar 24, 2015

yllierop mentioned this pull request Mar 24, 2015

WIP: Kubernetes WebUI #5790

Closed

googlebot added cla: yes and removed cla: no labels Mar 24, 2015

googlebot added cla: no and removed cla: yes labels Mar 24, 2015

googlebot added cla: yes and removed cla: no labels Mar 24, 2015

saad-ali assigned brendanburns Mar 24, 2015

brendandburns reviewed Mar 26, 2015
View reviewed changes

www/.travis.yml

@@ -0,0 +1,14 @@

language: node_js

Copy link

Contributor

brendandburns Mar 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete this file.

bgrant0607 assigned brendandburns and unassigned brendanburns Apr 6, 2015

googlebot added the cla: no label Apr 13, 2015

yllierop mentioned this pull request Apr 13, 2015

Add bower components to third party #6793

Merged

lavalamp reviewed Apr 17, 2015
View reviewed changes

initial commit of chrome only of new replacement web ui

99a43dc

googlebot added cla: yes and removed cla: no labels Apr 19, 2015

yllierop added 2 commits April 19, 2015 04:50

remove node modules

837a360

make new data file for web ui

76f162f

lavalamp reviewed Apr 20, 2015
View reviewed changes

lavalamp closed this Apr 21, 2015

yllierop unassigned lavalamp Aug 12, 2015

		@@ -0,0 +1,3 @@
		'use strict';

		describe("cAdvisor controller", function() { it("should work as intended", function() {}); });

WIP: Kubernetes WebUI #5834

WIP: Kubernetes WebUI #5834

Conversation

yllierop commented Mar 24, 2015

googlebot commented Mar 24, 2015

googlebot commented Mar 24, 2015

googlebot commented Mar 24, 2015

googlebot commented Mar 24, 2015

yllierop commented Mar 24, 2015

brendandburns Mar 26, 2015

Choose a reason for hiding this comment

brendandburns commented Mar 26, 2015

yllierop commented Mar 26, 2015

yllierop commented Mar 30, 2015

brendandburns commented Apr 7, 2015

jackgr commented Apr 7, 2015

yllierop commented Apr 7, 2015

brendandburns commented Apr 9, 2015

brendandburns commented Apr 9, 2015

yllierop commented Apr 9, 2015

yllierop commented Apr 9, 2015

bcbroussard commented Apr 13, 2015

googlebot commented Apr 13, 2015

googlebot commented Apr 14, 2015

bcbroussard commented Apr 14, 2015

googlebot commented Apr 14, 2015

googlebot commented Apr 14, 2015

googlebot commented Apr 14, 2015

yllierop commented Apr 14, 2015

lavalamp commented Apr 14, 2015

yllierop commented Apr 15, 2015

lavalamp commented Apr 15, 2015

yllierop commented Apr 17, 2015

lavalamp Apr 17, 2015

Choose a reason for hiding this comment

yllierop Apr 19, 2015

Choose a reason for hiding this comment

lavalamp commented Apr 17, 2015

lavalamp commented Apr 18, 2015

googlebot commented Apr 19, 2015

googlebot commented Apr 19, 2015

googlebot commented Apr 19, 2015

googlebot commented Apr 19, 2015

lavalamp Apr 20, 2015

Choose a reason for hiding this comment

lavalamp commented Apr 21, 2015